Source/bindings/scripts/CodeGeneratorV8.pm - Issue 14146021: Move deprecation messages to UseCounter::measureDeprecatedFeature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14146021: Move deprecation messages to UseCounter::measureDeprecatedFeature. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webaudio/deprecated-audiobuffersource-looping-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/CodeGeneratorV8.pm

diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm

index 9d3be35476b07f5341c6e0188df568d7713d1cd1..39924de35f13b9c1a2fb606a286d1c822d392371 100644

--- a/Source/bindings/scripts/CodeGeneratorV8.pm

+++ b/Source/bindings/scripts/CodeGeneratorV8.pm

@@ -969,7 +969,7 @@ sub GenerateDeprecationNotification

my $deprecateAs = shift;

if ($deprecateAs) {

AddToImplIncludes("PageConsole.h");

- return GenerateFeatureObservation($deprecateAs) . "\n PageConsole::reportDeprecation(activeDOMWindow(BindingState::instance()), PageConsole::${deprecateAs});\n";

+ return " UseCounter::measureDeprecatedFeature(activeDOMWindow(BindingState::instance()), UseCounter::${deprecateAs});\n";

}

return "";

}

« no previous file with comments | « LayoutTests/webaudio/deprecated-audiobuffersource-looping-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »