src/heap.cc - Issue 14146005: Track representations of fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 14146005: Track representations of fields (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Make double support consistent. Now DOUBLE always contains smi or heapnumber Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 10cb4738abdf66c07be84b3900eeb9dd2d95c553..b27e0f7b41715d6e493f808432253a2b7d8f26b2 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -4147,6 +4147,9 @@ MaybeObject* Heap::AllocateInitialMap(JSFunction* fun) {

String* name = fun->shared()->GetThisPropertyAssignmentName(i);

ASSERT(name->IsInternalizedString());

FieldDescriptor field(name, i, NONE, i + 1);

+ // TODO(verwaest): Since we cannot update the boilerplate's map yet,

+ // initialize to the worst case.

+ field.SetStorageType(TAGGED);

descriptors->Set(i, &field, witness);

}

descriptors->Sort();

« no previous file with comments | « src/flag-definitions.h ('k') | src/hydrogen.cc » ('j') | src/objects.cc » ('J')