Fix gyp/gn with configuration_policy=0

Fix gyp/gn with configuration_policy=0

Running gyp in chromium with configuration_policy set to 0 fails as
multiple targets that are behind condition of configuration_policy==1
are referenced without corresponding conditionals

BUG=530579
Committed: https://crrev.com/911ca660c71ffcf651e979e5585f783ad8d7fcd3
Cr-Commit-Position: refs/heads/master@{#355128}

[the_jk, 2015-10-20 14:01:18]

Description was changed from

==========
Fix gyp/gn with configuration_policy=0

Running gyp in chromium with configuration_policy set to 0 fails as
multiple targets that are behind condition of configuration_policy==1
are referenced without corresponding conditionals

BUG=530579
==========

to

==========
Fix gyp/gn with configuration_policy=0

Running gyp in chromium with configuration_policy set to 0 fails as
multiple targets that are behind condition of configuration_policy==1
are referenced without corresponding conditionals

BUG=530579
==========

[the_jk, 2015-10-20 14:01:19]

the_jk@opera.com changed reviewers:
+ blundell@chromium.org, michaelbai@chromium.org, sergeyu@chromium.org

[blundell, 2015-10-20 14:51:42]

//components lgtm

[Sergey Ulanov, 2015-10-20 16:16:21]

https://codereview.chromium.org/1414583004/diff/20001/remoting/remoting_host....
File remoting/remoting_host.gypi (right):

https://codereview.chromium.org/1414583004/diff/20001/remoting/remoting_host....
remoting/remoting_host.gypi:58: ['configuration_policy==1', {
It doesn't make sense to compile remoting_host target without policy. So if
configuration_policy is disabled then remoting host shoudl be disabled as well. 
I suggest changing remoting_enable.gypi so that remoting host is disabled if
policy is disabled.

[michaelbai, 2015-10-20 16:41:33]

android_webview lgtm

[the_jk, 2015-10-20 18:44:06]

On 2015/10/20 16:16:21, Sergey Ulanov wrote:
>
https://codereview.chromium.org/1414583004/diff/20001/remoting/remoting_host....
> File remoting/remoting_host.gypi (right):
> 
>
https://codereview.chromium.org/1414583004/diff/20001/remoting/remoting_host....
> remoting/remoting_host.gypi:58: ['configuration_policy==1', {
> It doesn't make sense to compile remoting_host target without policy. So if
> configuration_policy is disabled then remoting host shoudl be disabled as
well. 
> I suggest changing remoting_enable.gypi so that remoting host is disabled if
> policy is disabled.

Ah, thanks. Didn't notice because I did this fix outside the real project but of
course we don't
enable_remoting_host=1 while configuration_policy=0

[the_jk, 2015-10-20 18:44:17]

The CQ bit was checked by the_jk@opera.com

[the_jk, 2015-10-20 18:44:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelbai@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1414583004/#ps40001
(title: "Revert remoting_host change")

[commit-bot: I haz the power, 2015-10-20 18:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414583004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414583004/40001

[commit-bot: I haz the power, 2015-10-20 19:20:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-20 19:21:49]

Patchset 3 (id:??) landed as
https://crrev.com/911ca660c71ffcf651e979e5585f783ad8d7fcd3
Cr-Commit-Position: refs/heads/master@{#355128}