Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1414573003: Rename enums in WebPlatformEventType.h to follow blink style (Closed)

Created:
5 years, 2 months ago by Srirama
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, Inactive, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org, mlamouri+watch-test-runner_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename enums in WebPlatformEventType.h to follow blink style BUG=545539 Committed: https://crrev.com/4877ed23aecf0a365078ad43a89f71dfb46f91ac Cr-Commit-Position: refs/heads/master@{#355285}

Patch Set 1 #

Messages

Total messages: 13 (5 generated)
Srirama
PTAL
5 years, 2 months ago (2015-10-21 09:38:12 UTC) #4
timvolodine
lgtm but you'll need other owners as well. jochen@ would probably be a suitable candidate.
5 years, 2 months ago (2015-10-21 12:40:04 UTC) #5
Srirama
On 2015/10/21 12:40:04, timvolodine wrote: > lgtm but you'll need other owners as well. jochen@ ...
5 years, 2 months ago (2015-10-21 12:42:03 UTC) #6
Srirama
jochen@chromium.org: Owners review please.
5 years, 2 months ago (2015-10-21 12:42:37 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-21 13:03:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414573003/1
5 years, 2 months ago (2015-10-21 13:29:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 14:03:45 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 14:05:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4877ed23aecf0a365078ad43a89f71dfb46f91ac
Cr-Commit-Position: refs/heads/master@{#355285}

Powered by Google App Engine
This is Rietveld 408576698