Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1414563010: [sql] Disable memory-mapping under sql::Recovery. (Closed)

Created:
5 years, 1 month ago by Scott Hess - ex-Googler
Modified:
5 years, 1 month ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Disable memory-mapping under sql::Recovery. Recovery may be used to recover files with I/O errors, which would not interact well with memory-mapped I/O. [AFAICT, SQLite doesn't use memory-mapped I/O on temporary files, but as of yet I don't see why this might be.] BUG=551110 Committed: https://crrev.com/2f3a814be066d8c02ba8b82f003cd98799165882 Cr-Commit-Position: refs/heads/master@{#358083}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M sql/connection.cc View 2 chunks +19 lines, -12 lines 1 comment Download
M sql/recovery.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M sql/recovery_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Scott Hess - ex-Googler
I was working on I/O error handling WRT sql::Recovery, and it occurred to me that ...
5 years, 1 month ago (2015-11-04 23:34:59 UTC) #2
Scott Hess - ex-Googler
https://codereview.chromium.org/1414563010/diff/1/sql/connection.cc File sql/connection.cc (right): https://codereview.chromium.org/1414563010/diff/1/sql/connection.cc#newcode1677 sql/connection.cc:1677: Hmm, and I moved the stanza down here because ...
5 years, 1 month ago (2015-11-04 23:36:42 UTC) #3
rmcilroy
lgtm
5 years, 1 month ago (2015-11-05 11:21:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414563010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414563010/1
5 years, 1 month ago (2015-11-05 18:06:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 18:11:16 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 18:11:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f3a814be066d8c02ba8b82f003cd98799165882
Cr-Commit-Position: refs/heads/master@{#358083}

Powered by Google App Engine
This is Rietveld 408576698