Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1414563002: Test SkRemote on GCE bots. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Test SkRemote on GCE bots. This will get us gathering GM images. I will set up ignores on gold.skia.org so no one's bothered. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ff8b3f0f652fd1c1ae8b88eda2478d16d6ab6c37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/dm_flags.json View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414563002/1
5 years, 2 months ago (2015-10-16 21:50:21 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 22:02:55 UTC) #4
mtklein
5 years, 2 months ago (2015-10-16 22:03:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414563002/1
5 years, 2 months ago (2015-10-16 22:16:04 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-16 22:16:05 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 2 months ago (2015-10-17 04:16:04 UTC) #11
mtklein
If you're active this weekend, let's land this before Monday. Seems I can't set up ...
5 years, 2 months ago (2015-10-17 13:01:14 UTC) #12
mtklein
https://gold.skia.org/search2?issue=1414563002&unt=true&query=source_type%3Dgm&master=false
5 years, 2 months ago (2015-10-17 13:03:13 UTC) #13
hal.canary
On 2015/10/17 13:03:13, mtklein wrote: > https://gold.skia.org/search2?issue=1414563002&unt=true&query=source_type%3Dgm&master=false lgtm.
5 years, 2 months ago (2015-10-17 15:22:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414563002/1
5 years, 2 months ago (2015-10-17 16:24:35 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-17 16:25:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ff8b3f0f652fd1c1ae8b88eda2478d16d6ab6c37

Powered by Google App Engine
This is Rietveld 408576698