third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and applied senorblanco+haraken feedbac Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp b/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

index ac061a8c15d90223515a1e188ac4ed39eaf7294b..784a9f0c9140286e17dbf2df9a5a27c88005e9ec 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

@@ -19,11 +19,11 @@ PushEvent::PushEvent(const AtomicString& type, PushMessageData* data, WaitUntilO

{

}

-PushEvent::PushEvent(const AtomicString& type, const PushEventInit& initializer)

+PushEvent::PushEvent(const AtomicString& type, const PushEventInit& initializer, ExceptionState& exceptionState)

: ExtendableEvent(type, initializer)

{

if (initializer.hasData())

- m_data = PushMessageData::create(initializer.data());

+ m_data = PushMessageData::create(initializer.data(), exceptionState);

}

PushEvent::~PushEvent()