third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and applied senorblanco+haraken feedbac Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp » ('j') | third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

index 48eeb0c2ff23f861597c0939dc803a738f35cb9c..d6259683a7a88125fc2d201df0018543179c8383 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

@@ -217,7 +217,8 @@ TEST_F(CanvasRenderingContext2DAPITest, CreateImageData)

// createImageData(imageData) should create a new ImageData of the same size as 'imageData'

// but filled with transparent black

- ImageData* sameSizeImageData = context2d()->createImageData(imageData);

+ ImageData* sameSizeImageData = context2d()->createImageData(imageData, exceptionState);

+ EXPECT_FALSE(exceptionState.hadException());

EXPECT_EQ(100, sameSizeImageData->width());

EXPECT_EQ(50, sameSizeImageData->height());

EXPECT_EQ(0, sameSizeImageData->data()->data()[32]);