third_party/WebKit/Source/web/WebSocketImpl.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebSocketImpl.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: applied review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebSocketImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebSocketImpl.cpp b/third_party/WebKit/Source/web/WebSocketImpl.cpp

index 9f453f13a1310e4b483d5e26c27698bcec77ed41..b7fe4c879c93715da59fb04e9cf88ef87d14ecbd 100644

--- a/third_party/WebKit/Source/web/WebSocketImpl.cpp

+++ b/third_party/WebKit/Source/web/WebSocketImpl.cpp

@@ -172,7 +172,9 @@ void WebSocketImpl::didReceiveBinaryMessage(PassOwnPtr<Vector<char>> payload)

// FIXME: Handle Blob after supporting WebBlob.

break;

case BinaryTypeArrayBuffer:

- m_client->didReceiveArrayBuffer(WebArrayBuffer(DOMArrayBuffer::create(payload->data(), payload->size())));

+ RefPtr<DOMArrayBuffer> buffer = DOMArrayBuffer::createOrNull(payload->data(), payload->size());

+ if (buffer)

+ m_client->didReceiveArrayBuffer(WebArrayBuffer(buffer.release()));

break;

}