third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: applied review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp b/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

index 9ea9e0dfdf9266329deb5761592abde71230d524..cf4010bcb93de89cc2963f335f6f4bf3230c7f42 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp

@@ -215,7 +215,11 @@ void MIDIOutput::send(Vector<unsigned> unsignedData, double timestamp, Exception

if (timestamp == 0.0)

timestamp = now(executionContext());

- RefPtr<DOMUint8Array> array = DOMUint8Array::create(unsignedData.size());

+ RefPtr<DOMUint8Array> array = DOMUint8Array::createOrNull(unsignedData.size());

+ if (!array) {

+ exceptionState.throwRangeError("Out of memory.");

+ return;

+ }

DOMUint8Array::ValueType* const arrayData = array->data();

const uint32_t arrayLength = array->length();