third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: applied review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp ('K') | « third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl

index 9af96dbb32f13dcc0bf30389489fd104df617bba..a527522325c618450756a0314415f884bdd4e84d 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl

+++ b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl

@@ -11,7 +11,7 @@ typedef object JSON;

GarbageCollected,

RuntimeEnabled=PushMessagingData,

] interface PushMessageData {

- ArrayBuffer arrayBuffer();

+ [RaisesException] ArrayBuffer arrayBuffer();

Blob blob();

[CallWith=ScriptState, RaisesException] JSON json();

USVString text();