third_party/WebKit/Source/core/html/HTMLCanvasElement.h - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: applied review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

index f8b1b19abcd8ac856b20ee4c9e9f5132794baa76..1eecd854a1c827643b382f7a5c33880308ece001 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

@@ -214,8 +214,8 @@ private:

bool paintsIntoCanvasBuffer() const;

- ImageData* toImageData(SourceDrawingBuffer) const;

- String toDataURLInternal(const String& mimeType, const double& quality, SourceDrawingBuffer) const;

+ ImageData* toImageData(SourceDrawingBuffer, ExceptionState&) const;

+ String toDataURLInternal(const String& mimeType, const double& quality, SourceDrawingBuffer, ExceptionState&) const;

static void encodeImageAsync(DOMUint8ClampedArray* imagedata, IntSize imageSize, FileCallback*, const String& mimeType, double quality);

static void createBlobAndCall(PassOwnPtr<Vector<char>> encodedImage, const String& mimeType, FileCallback*);