third_party/WebKit/Source/core/dom/DOMTypedArray.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMTypedArray.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: applied review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DOMTypedArray.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMTypedArray.cpp b/third_party/WebKit/Source/core/dom/DOMTypedArray.cpp

index 676fe8d9d89510950de0e007051977ec41759432..3e699ad86e99baf9e195e9832dcd76cc61e561b1 100644

--- a/third_party/WebKit/Source/core/dom/DOMTypedArray.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMTypedArray.cpp

@@ -30,7 +30,7 @@ v8::Local<v8::Object> DOMTypedArray<WTFTypedArray, V8TypedArray>::wrap(v8::Isola

ASSERT(!DOMDataStore::containsWrapper(this, isolate));

const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();

- RefPtr<DOMArrayBufferBase> buffer = this->bufferBase();

+ RefPtr<DOMArrayBufferBase> buffer = this->bufferBaseOrNull();

v8::Local<v8::Value> v8Buffer = toV8(buffer.get(), creationContext, isolate);

if (v8Buffer.IsEmpty())

return v8::Local<v8::Object>();