third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: applied review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

index 3b2bb63b4e6f562c4e63045a2ff654178ae406b5..1bc840dbdc152f1323c33d858652673b981d785f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

@@ -527,7 +527,7 @@ private:

bool readNumberObject(v8::Local<v8::Value>*);

bool readImageData(v8::Local<v8::Value>*);

bool readCompositorProxy(v8::Local<v8::Value>*);

- PassRefPtr<DOMArrayBuffer> doReadArrayBuffer();

+ PassRefPtr<DOMArrayBuffer> doReadArrayBufferOrNull();

bool readArrayBuffer(v8::Local<v8::Value>*);

bool readArrayBufferView(v8::Local<v8::Value>*, ScriptValueCompositeCreator&);

bool readRegExp(v8::Local<v8::Value>*);