Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/wtf/Float64Array.h

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+more tweaks Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/Float32Array.h ('k') | third_party/WebKit/Source/wtf/Int16Array.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/Float64Array.h
diff --git a/third_party/WebKit/Source/wtf/Float64Array.h b/third_party/WebKit/Source/wtf/Float64Array.h
index 14be7a2861bec64ee795e28ef33312911eb7a441..39c2461005eb144a1cd03433dcc1ef77254ce287 100644
--- a/third_party/WebKit/Source/wtf/Float64Array.h
+++ b/third_party/WebKit/Source/wtf/Float64Array.h
@@ -34,14 +34,11 @@ namespace WTF {
class Float64Array final : public TypedArrayBase<double> {
public:
- static inline PassRefPtr<Float64Array> create(unsigned length);
- static inline PassRefPtr<Float64Array> create(const double* array, unsigned length);
+ static inline PassRefPtr<Float64Array> createOrNull(unsigned length);
+ static inline PassRefPtr<Float64Array> createOrNull(const double* array, unsigned length);
+ static inline PassRefPtr<Float64Array> deprecatedCreateOrCrash(const double* array, unsigned length);
static inline PassRefPtr<Float64Array> create(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned length);
- // Should only be used when it is known the entire array will be filled. Do
- // not return these results directly to JavaScript without filling first.
- static inline PassRefPtr<Float64Array> createUninitialized(unsigned length);
-
using TypedArrayBase<double>::set;
void set(unsigned index, double value)
@@ -62,14 +59,19 @@ private:
friend class TypedArrayBase<double>;
};
-PassRefPtr<Float64Array> Float64Array::create(unsigned length)
+PassRefPtr<Float64Array> Float64Array::createOrNull(unsigned length)
+{
+ return TypedArrayBase<double>::createOrNull<Float64Array>(length);
+}
+
+PassRefPtr<Float64Array> Float64Array::createOrNull(const double* array, unsigned length)
{
- return TypedArrayBase<double>::create<Float64Array>(length);
+ return TypedArrayBase<double>::createOrNull<Float64Array>(array, length);
}
-PassRefPtr<Float64Array> Float64Array::create(const double* array, unsigned length)
+PassRefPtr<Float64Array> Float64Array::deprecatedCreateOrCrash(const double* array, unsigned length)
{
- return TypedArrayBase<double>::create<Float64Array>(array, length);
+ return TypedArrayBase<double>::deprecatedCreateOrCrash<Float64Array>(array, length);
}
PassRefPtr<Float64Array> Float64Array::create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length)
« no previous file with comments | « third_party/WebKit/Source/wtf/Float32Array.h ('k') | third_party/WebKit/Source/wtf/Int16Array.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698