third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase+more tweaks Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

index a114ff4862fc9f61b9b89f69a592fa6e2c26a797..03d55dab499160e4453cb97be64855b2c2ecff29 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

@@ -21,6 +21,7 @@ PushSubscription* PushSubscription::take(ScriptPromiseResolver*, PassOwnPtr<WebP

{

if (!pushSubscription)

return nullptr;

return new PushSubscription(*pushSubscription, serviceWorkerRegistration);

}

@@ -32,7 +33,7 @@ void PushSubscription::dispose(WebPushSubscription* pushSubscription)

PushSubscription::PushSubscription(const WebPushSubscription& subscription, ServiceWorkerRegistration* serviceWorkerRegistration)

: m_endpoint(subscription.endpoint)

- , m_p256dh(DOMArrayBuffer::create(subscription.p256dh.data(), subscription.p256dh.size()))

+ , m_p256dh(DOMArrayBuffer::deprecatedCreateOrCrash(subscription.p256dh.data(), subscription.p256dh.size()))

, m_serviceWorkerRegistration(serviceWorkerRegistration)

{

}