third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase+more tweaks Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/ConvertWebVectorToArrayBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

index b76c2ebad454aa9c00856457170f0ae306f11360..4213b141ed7fe8b3e6211a0c02049bb3dd47851e 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

@@ -45,7 +45,10 @@ void BluetoothGATTCharacteristic::dispatchCharacteristicValueChanged(

{

static_assert(sizeof(*value.data()) == 1, "uint8_t should be a single byte");

- m_value = DOMArrayBuffer::create(value.data(), value.size());

+ // TODO(junov): crbug.com/536816

+ // Should use createOrNull. Requires figuring out a graceful way

+ // to handle allocation failures.

+ m_value = DOMArrayBuffer::deprecatedCreateOrCrash(value.data(), value.size());

dispatchEvent(Event::create(EventTypeNames::characteristicvaluechanged));

}