Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+more tweaks Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
index aa8877c95d1639df5c10f447eaa832765ef66e77..656faad126998082c2b7b712507a95969c920154 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
@@ -96,9 +96,17 @@ v8::Local<v8::Value> toV8(const IDBKey* key, v8::Local<v8::Object> creationConte
case IDBKey::StringType:
return v8String(isolate, key->string());
case IDBKey::BinaryType:
- // Experimental feature: binary keys
- // https://w3c.github.io/IndexedDB/#steps-to-convert-a-key-to-a-value
- return toV8(DOMArrayBuffer::create(reinterpret_cast<const unsigned char*>(key->binary()->data()), key->binary()->size()), creationContext, isolate);
+ {
+ // Experimental feature: binary keys
+ // https://w3c.github.io/IndexedDB/#steps-to-convert-a-key-to-a-value
+
+ // TODO(junov): crbug.com/536816 Find a more graceful way to handle allocation
+ // failures with createOrNull. It would be possible to throw a RangeError
+ // from here but the consequences of such a change need to be considered
+ // carefully.
+ RefPtr<DOMArrayBuffer> buffer = DOMArrayBuffer::deprecatedCreateOrCrash(reinterpret_cast<const unsigned char*>(key->binary()->data()), key->binary()->size());
+ return toV8(buffer, creationContext, isolate);
+ }
case IDBKey::DateType:
return v8::Date::New(context, key->date()).ToLocalChecked();
case IDBKey::ArrayType:

Powered by Google App Engine
This is Rietveld 408576698