third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp - Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/DOMTypedArray.h ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp ('k') | third_party/WebKit/Source/modules/crypto/CryptoKey.cpp » ('j') | third_party/WebKit/Source/wtf/ArrayBufferBuilder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

index 622c5e23dcafab48cf975a0751c4cb5287b85c5a..9967880200cf6c2515c373bbc4ab727c98cb092d 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

@@ -141,10 +141,12 @@ void CanvasRenderingContext2DTest::SetUp()

m_document->view()->updateAllLifecyclePhases();

m_canvasElement = toHTMLCanvasElement(m_document->getElementById("c"));

- m_fullImageData = ImageData::create(IntSize(10, 10));

- m_partialImageData = ImageData::create(IntSize(2, 2));

NonThrowableExceptionState exceptionState;

+ m_fullImageData = ImageData::create(IntSize(10, 10), exceptionState);

+ EXPECT_FALSE(exceptionState.hadException());

+ m_partialImageData = ImageData::create(IntSize(2, 2), exceptionState);

+ EXPECT_FALSE(exceptionState.hadException());

CanvasGradient* opaqueGradient = CanvasGradient::create(FloatPoint(0, 0), FloatPoint(10, 0));

opaqueGradient->addColorStop(0, String("green"), exceptionState);

EXPECT_FALSE(exceptionState.hadException());