Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: third_party/WebKit/Source/core/dom/DOMArrayBufferView.h

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMArrayBufferView.h
diff --git a/third_party/WebKit/Source/core/dom/DOMArrayBufferView.h b/third_party/WebKit/Source/core/dom/DOMArrayBufferView.h
index 889585da8a5b665ca8730f83a288f48b32380038..e6a0eb3e2313bf00efbb22394a36ef29425eef83 100644
--- a/third_party/WebKit/Source/core/dom/DOMArrayBufferView.h
+++ b/third_party/WebKit/Source/core/dom/DOMArrayBufferView.h
@@ -31,30 +31,30 @@ public:
virtual ~DOMArrayBufferView() { }
- PassRefPtr<DOMArrayBuffer> buffer() const
+ PassRefPtr<DOMArrayBuffer> bufferOrNull() const
{
ASSERT(!isShared());
if (!m_domArrayBuffer) {
- m_domArrayBuffer = DOMArrayBuffer::create(view()->buffer());
+ m_domArrayBuffer = DOMArrayBuffer::createOrNull(view()->buffer());
}
return static_pointer_cast<DOMArrayBuffer>(m_domArrayBuffer);
}
- PassRefPtr<DOMSharedArrayBuffer> bufferShared() const
+ PassRefPtr<DOMSharedArrayBuffer> bufferSharedOrNull() const
{
ASSERT(isShared());
if (!m_domArrayBuffer) {
- m_domArrayBuffer = DOMSharedArrayBuffer::create(view()->buffer());
+ m_domArrayBuffer = DOMSharedArrayBuffer::createOrNull(view()->buffer());
}
return static_pointer_cast<DOMSharedArrayBuffer>(m_domArrayBuffer);
}
- PassRefPtr<DOMArrayBufferBase> bufferBase() const
+ PassRefPtr<DOMArrayBufferBase> bufferBaseOrNull() const
{
if (isShared()) {
- return bufferShared();
+ return bufferSharedOrNull();
}
- return buffer();
+ return bufferOrNull();
}
const WTF::ArrayBufferView* view() const { return m_bufferView.get(); }

Powered by Google App Engine
This is Rietveld 408576698