Fix out-of-memory crashes related to ArrayBuffer allocation

third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/websockets/DOMWebSocket.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
@@ skipping 581 matching lines @@
         0x0000
     };
     m_websocket->send(nonLatin1String, m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
     EXPECT_EQ(DOMWebSocket::OPEN, m_websocket->readyState());
 }
 
 TEST_F(DOMWebSocketTest, sendArrayBufferWhenConnecting)
 {
-    RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
+    RefPtr<DOMArrayBufferView> view = DOMUint8Array::deprecatedCreateOrCrash(8);
     {
         InSequence s;
         EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
     }
     m_websocket->connect("ws://example.com/", Vector<String>(), m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
 
-    m_websocket->send(view->buffer().get(), m_exceptionState);
+    RefPtr<DOMArrayBuffer> buffer = view->bufferOrNull();
+    RELEASE_ASSERT(buffer); // Out of memory?
+    m_websocket->send(buffer.get(), m_exceptionState);
 
     EXPECT_TRUE(m_exceptionState.hadException());
     EXPECT_EQ(InvalidStateError, m_exceptionState.code());
     EXPECT_EQ("Still in CONNECTING state.", m_exceptionState.message());
     EXPECT_EQ(DOMWebSocket::CONNECTING, m_websocket->readyState());
 }
 
 TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosing)
 {
-    RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
+    RefPtr<DOMArrayBufferView> view = DOMUint8Array::deprecatedCreateOrCrash(8);
     {
         InSequence s;
         EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
         EXPECT_CALL(channel(), fail(_, _, _, _));
     }
     m_websocket->connect("ws://example.com/", Vector<String>(), m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
 
     m_websocket->close(m_exceptionState);
     EXPECT_FALSE(m_exceptionState.hadException());
 
-    m_websocket->send(view->buffer().get(), m_exceptionState);
+    RefPtr<DOMArrayBuffer> buffer = view->bufferOrNull();
+    RELEASE_ASSERT(buffer); // Out of memory?
+    m_websocket->send(buffer.get(), m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
     EXPECT_EQ(DOMWebSocket::CLOSING, m_websocket->readyState());
 }
 
 TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosed)
 {
     Checkpoint checkpoint;
-    RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
+    RefPtr<DOMArrayBufferView> view = DOMUint8Array::deprecatedCreateOrCrash(8);
     {
         InSequence s;
         EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
         EXPECT_CALL(channel(), disconnect());
         EXPECT_CALL(checkpoint, Call(1));
     }
     m_websocket->connect("ws://example.com/", Vector<String>(), m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
 
     m_websocket->didClose(WebSocketChannelClient::ClosingHandshakeIncomplete, 1006, "");
     checkpoint.Call(1);
 
-    m_websocket->send(view->buffer().get(), m_exceptionState);
+    RefPtr<DOMArrayBuffer> buffer = view->bufferOrNull();
+    RELEASE_ASSERT(buffer); // Out of memory?
+    m_websocket->send(buffer.get(), m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
     EXPECT_EQ(DOMWebSocket::CLOSED, m_websocket->readyState());
 }
 
 TEST_F(DOMWebSocketTest, sendArrayBufferSuccess)
 {
-    RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
+    RefPtr<DOMArrayBufferView> view = DOMUint8Array::deprecatedCreateOrCrash(8);
     {
         InSequence s;
         EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
-        EXPECT_CALL(channel(), send(Ref(*view->buffer()), 0, 8));
+        RefPtr<DOMArrayBuffer> buffer = view->bufferOrNull();
+        RELEASE_ASSERT(buffer); // Out of momry?

[haraken, 2015/10/29 18:58:37]

memory

+        EXPECT_CALL(channel(), send(Ref(*buffer), 0, 8));
     }
     m_websocket->connect("ws://example.com/", Vector<String>(), m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
 
     m_websocket->didConnect("", "");
-    m_websocket->send(view->buffer().get(), m_exceptionState);
+    RefPtr<DOMArrayBuffer> buffer = view->bufferOrNull();
+    RELEASE_ASSERT(buffer); // Out of momry?

[haraken, 2015/10/29 18:58:37]

memory

+    m_websocket->send(buffer.get(), m_exceptionState);
 
     EXPECT_FALSE(m_exceptionState.hadException());
     EXPECT_EQ(DOMWebSocket::OPEN, m_websocket->readyState());
 }
 
 // FIXME: We should have Blob tests here.
 // We can't create a Blob because the blob registration cannot be mocked yet.
 
 // FIXME: We should add tests for bufferedAmount.
 
@@ skipping 59 matching lines @@
     EXPECT_EQ(InvalidAccessError, m_exceptionState.code());
     EXPECT_EQ(String::format("The code must be either 1000, or between 3000 and 4999. %d is neither.", GetParam()), m_exceptionState.message());
     EXPECT_EQ(DOMWebSocket::CONNECTING, m_websocket->readyState());
 }
 
 INSTANTIATE_TEST_CASE_P(DOMWebSocketInvalidClosingCode, DOMWebSocketInvalidClosingCodeTest, ::testing::Values(0, 1, 998, 999, 1001, 2999, 5000, 9999, 65535));
 
 } // namespace
 
 } // namespace blink