Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: third_party/WebKit/Source/modules/bluetooth/ConvertWebVectorToArrayBuffer.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+more tweaks Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/bluetooth/ConvertWebVectorToArrayBuffer.h" 6 #include "modules/bluetooth/ConvertWebVectorToArrayBuffer.h"
7 7
8 namespace blink { 8 namespace blink {
9 9
10 PassRefPtr<DOMArrayBuffer> ConvertWebVectorToArrayBuffer::take(ScriptPromiseReso lver*, const WebVector<uint8_t>& webVector) 10 PassRefPtr<DOMArrayBuffer> ConvertWebVectorToArrayBuffer::take(ScriptPromiseReso lver*, const WebVector<uint8_t>& webVector)
11 { 11 {
12 static_assert(sizeof(*webVector.data()) == 1, "uint8_t should be a single by te"); 12 static_assert(sizeof(*webVector.data()) == 1, "uint8_t should be a single by te");
13 13 // TODO(junov): crbug.com/536816
14 RefPtr<DOMArrayBuffer> domBuffer = DOMArrayBuffer::create(webVector.data(), webVector.size()); 14 // We should use DOMArrayBuffer::createOrNull here, but dealing
15 15 // with the null case is tricky because CallbackPromiseAdapter
16 // was not designed to allow the promise to be rejected in the success
17 // handler.
18 // The right thing to do would probably be to reject the promise with
19 // a RangeError exception when the ArrayBuffer allocation fails.
20 RefPtr<DOMArrayBuffer> domBuffer = DOMArrayBuffer::deprecatedCreateOrCrash(w ebVector.data(), webVector.size());
16 return domBuffer; 21 return domBuffer;
17 } 22 }
18 23
19 } // namespace blink 24 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698