Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp

Issue 1414553002: Fix out-of-memory crashes related to ArrayBuffer allocation Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+more tweaks Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 PassRefPtr<DOMArrayBuffer> FileReaderSync::readAsArrayBuffer(ExecutionContext* e xecutionContext, Blob* blob, ExceptionState& exceptionState) 48 PassRefPtr<DOMArrayBuffer> FileReaderSync::readAsArrayBuffer(ExecutionContext* e xecutionContext, Blob* blob, ExceptionState& exceptionState)
49 { 49 {
50 if (!blob) { 50 if (!blob) {
51 exceptionState.throwDOMException(NotFoundError, FileError::notFoundError Message); 51 exceptionState.throwDOMException(NotFoundError, FileError::notFoundError Message);
52 return nullptr; 52 return nullptr;
53 } 53 }
54 54
55 FileReaderLoader loader(FileReaderLoader::ReadAsArrayBuffer, nullptr); 55 FileReaderLoader loader(FileReaderLoader::ReadAsArrayBuffer, nullptr);
56 startLoading(executionContext, loader, *blob, exceptionState); 56 startLoading(executionContext, loader, *blob, exceptionState);
57 57
58 return loader.arrayBufferResult(); 58 return loader.arrayBufferResultOrNull();
59 } 59 }
60 60
61 String FileReaderSync::readAsBinaryString(ExecutionContext* executionContext, Bl ob* blob, ExceptionState& exceptionState) 61 String FileReaderSync::readAsBinaryString(ExecutionContext* executionContext, Bl ob* blob, ExceptionState& exceptionState)
62 { 62 {
63 if (!blob) { 63 if (!blob) {
64 exceptionState.throwDOMException(NotFoundError, FileError::notFoundError Message); 64 exceptionState.throwDOMException(NotFoundError, FileError::notFoundError Message);
65 return String(); 65 return String();
66 } 66 }
67 67
68 FileReaderLoader loader(FileReaderLoader::ReadAsBinaryString, 0); 68 FileReaderLoader loader(FileReaderLoader::ReadAsBinaryString, 0);
(...skipping 28 matching lines...) Expand all
97 } 97 }
98 98
99 void FileReaderSync::startLoading(ExecutionContext* executionContext, FileReader Loader& loader, const Blob& blob, ExceptionState& exceptionState) 99 void FileReaderSync::startLoading(ExecutionContext* executionContext, FileReader Loader& loader, const Blob& blob, ExceptionState& exceptionState)
100 { 100 {
101 loader.start(executionContext, blob.blobDataHandle()); 101 loader.start(executionContext, blob.blobDataHandle());
102 if (loader.errorCode()) 102 if (loader.errorCode())
103 FileError::throwDOMException(exceptionState, loader.errorCode()); 103 FileError::throwDOMException(exceptionState, loader.errorCode());
104 } 104 }
105 105
106 } // namespace blink 106 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698