Fix out-of-memory crashes related to ArrayBuffer allocation

third_party/WebKit/Source/wtf/Float32Array.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 16 matching lines @@
 #ifndef Float32Array_h
 #define Float32Array_h
 
 #include "wtf/MathExtras.h"
 #include "wtf/TypedArrayBase.h"
 
 namespace WTF {
 
 class Float32Array final : public TypedArrayBase<float> {
 public:
-    static inline PassRefPtr<Float32Array> create(unsigned length);
-    static inline PassRefPtr<Float32Array> create(const float* array, unsigned length);
     static inline PassRefPtr<Float32Array> create(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned length);
-
+    static inline PassRefPtr<Float32Array> createOrNull(const float* array, unsigned length);
+    static inline PassRefPtr<Float32Array> deprecatedCreateOrCrash(const float* array, unsigned length); // Prefer createOrNull
     static inline PassRefPtr<Float32Array> createOrNull(unsigned length);
 
     using TypedArrayBase<float>::set;
 
     void set(unsigned index, double value)
     {
         if (index >= TypedArrayBase<float>::m_length)
             return;
         TypedArrayBase<float>::data()[index] = static_cast<float>(value);
     }
 
     ViewType type() const override
     {
         return TypeFloat32;
     }
 
 private:
     inline Float32Array(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned length);
     // Make constructor visible to superclass.
     friend class TypedArrayBase<float>;
 };
 
-PassRefPtr<Float32Array> Float32Array::create(unsigned length)
+PassRefPtr<Float32Array> Float32Array::createOrNull(unsigned length)
 {
-    return TypedArrayBase<float>::create<Float32Array>(length);
+    return TypedArrayBase<float>::createOrNull<Float32Array>(length);
 }
 
-PassRefPtr<Float32Array> Float32Array::create(const float* array, unsigned length)
+PassRefPtr<Float32Array> Float32Array::createOrNull(const float* array, unsigned length)
 {
-    return TypedArrayBase<float>::create<Float32Array>(array, length);
+    return TypedArrayBase<float>::createOrNull<Float32Array>(array, length);
+}
+
+PassRefPtr<Float32Array> Float32Array::deprecatedCreateOrCrash(const float* array, unsigned length)
+{
+    return TypedArrayBase<float>::createOrNull<Float32Array>(array, length);

[binji, 2015/10/16 22:12:39]

should be deprecatedCreateOrCrash?

[Justin Novosad, 2015/10/19 16:42:52]

Acknowledged.

 }
 
 PassRefPtr<Float32Array> Float32Array::create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length)
 {
     return TypedArrayBase<float>::create<Float32Array>(buffer, byteOffset, length);
 }
 
-PassRefPtr<Float32Array> Float32Array::createOrNull(unsigned length)
-{
-    return TypedArrayBase<float>::createOrNull<Float32Array>(length);
-}
-
 Float32Array::Float32Array(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length)
     : TypedArrayBase<float>(buffer, byteOffset, length)
 {
 }
 
 } // namespace WTF
 
 using WTF::Float32Array;
 
 #endif // Float32Array_h