ipc/ipc_message_attachment_set.h - Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_attachment_set.h

Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from tsepez. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_message_attachment_set.h

diff --git a/ipc/ipc_message_attachment_set.h b/ipc/ipc_message_attachment_set.h

index 4276fcd9cdc14d899a1863c5467dc0c5895c4479..6a94b1946d12f9b640d188a0c51b0bb5a1920d7a 100644

--- a/ipc/ipc_message_attachment_set.h

+++ b/ipc/ipc_message_attachment_set.h

@@ -87,7 +87,8 @@ class IPC_EXPORT MessageAttachmentSet

void CommitAllDescriptors();

// Returns a vector of all brokerable attachments.

- std::vector<BrokerableAttachment*> GetBrokerableAttachments() const;

+ std::vector<scoped_refptr<IPC::BrokerableAttachment>>

+ GetBrokerableAttachments() const;

// Replaces a placeholder brokerable attachment with |attachment|, matching

// them by their id.

« no previous file with comments | « ipc/ipc_message.cc ('k') | ipc/ipc_message_attachment_set.cc » ('j') | no next file with comments »