Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: ipc/ipc_message_attachment_set.h

Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from tsepez. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_message.cc ('k') | ipc/ipc_message_attachment_set.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_IPC_MESSAGE_ATTACHMENT_SET_H_ 5 #ifndef IPC_IPC_MESSAGE_ATTACHMENT_SET_H_
6 #define IPC_IPC_MESSAGE_ATTACHMENT_SET_H_ 6 #define IPC_IPC_MESSAGE_ATTACHMENT_SET_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 // Similar to GetNonBrokerableAttachmentAt, but there are no ordering 80 // Similar to GetNonBrokerableAttachmentAt, but there are no ordering
81 // requirements. 81 // requirements.
82 scoped_refptr<MessageAttachment> GetBrokerableAttachmentAt(unsigned index); 82 scoped_refptr<MessageAttachment> GetBrokerableAttachmentAt(unsigned index);
83 83
84 // This must be called after transmitting the descriptors returned by 84 // This must be called after transmitting the descriptors returned by
85 // PeekDescriptors. It marks all the non-brokerable descriptors as consumed 85 // PeekDescriptors. It marks all the non-brokerable descriptors as consumed
86 // and closes those which are auto-close. 86 // and closes those which are auto-close.
87 void CommitAllDescriptors(); 87 void CommitAllDescriptors();
88 88
89 // Returns a vector of all brokerable attachments. 89 // Returns a vector of all brokerable attachments.
90 std::vector<BrokerableAttachment*> GetBrokerableAttachments() const; 90 std::vector<scoped_refptr<IPC::BrokerableAttachment>>
91 GetBrokerableAttachments() const;
91 92
92 // Replaces a placeholder brokerable attachment with |attachment|, matching 93 // Replaces a placeholder brokerable attachment with |attachment|, matching
93 // them by their id. 94 // them by their id.
94 void ReplacePlaceholderWithAttachment( 95 void ReplacePlaceholderWithAttachment(
95 const scoped_refptr<BrokerableAttachment>& attachment); 96 const scoped_refptr<BrokerableAttachment>& attachment);
96 97
97 #if defined(OS_POSIX) 98 #if defined(OS_POSIX)
98 // This is the maximum number of descriptors per message. We need to know this 99 // This is the maximum number of descriptors per message. We need to know this
99 // because the control message kernel interface has to be given a buffer which 100 // because the control message kernel interface has to be given a buffer which
100 // is large enough to store all the descriptor numbers. Otherwise the kernel 101 // is large enough to store all the descriptor numbers. Otherwise the kernel
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 // all the descriptors have been read (with GetNthDescriptor). Secondly, we 151 // all the descriptors have been read (with GetNthDescriptor). Secondly, we
151 // can check that they are read in order. 152 // can check that they are read in order.
152 mutable unsigned consumed_descriptor_highwater_; 153 mutable unsigned consumed_descriptor_highwater_;
153 154
154 DISALLOW_COPY_AND_ASSIGN(MessageAttachmentSet); 155 DISALLOW_COPY_AND_ASSIGN(MessageAttachmentSet);
155 }; 156 };
156 157
157 } // namespace IPC 158 } // namespace IPC
158 159
159 #endif // IPC_IPC_MESSAGE_ATTACHMENT_SET_H_ 160 #endif // IPC_IPC_MESSAGE_ATTACHMENT_SET_H_
OLDNEW
« no previous file with comments | « ipc/ipc_message.cc ('k') | ipc/ipc_message_attachment_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698