Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: ipc/attachment_broker_privileged_mac.h

Issue 1414503009: IPC: Remove unnecessary conversions of BrokerableAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from tsepez. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/attachment_broker_mac_unittest.cc ('k') | ipc/attachment_broker_privileged_mac.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_ATTACHMENT_BROKER_PRIVILEGED_MAC_H_ 5 #ifndef IPC_ATTACHMENT_BROKER_PRIVILEGED_MAC_H_
6 #define IPC_ATTACHMENT_BROKER_PRIVILEGED_MAC_H_ 6 #define IPC_ATTACHMENT_BROKER_PRIVILEGED_MAC_H_
7 7
8 #include <mach/mach.h> 8 #include <mach/mach.h>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // 48 //
49 // For the rest of this file, and the corresponding implementation file, R will 49 // For the rest of this file, and the corresponding implementation file, R will
50 // be called the "intermediate Mach port" and M3 the "final Mach port". 50 // be called the "intermediate Mach port" and M3 the "final Mach port".
51 class IPC_EXPORT AttachmentBrokerPrivilegedMac 51 class IPC_EXPORT AttachmentBrokerPrivilegedMac
52 : public AttachmentBrokerPrivileged { 52 : public AttachmentBrokerPrivileged {
53 public: 53 public:
54 explicit AttachmentBrokerPrivilegedMac(base::PortProvider* port_provider); 54 explicit AttachmentBrokerPrivilegedMac(base::PortProvider* port_provider);
55 ~AttachmentBrokerPrivilegedMac() override; 55 ~AttachmentBrokerPrivilegedMac() override;
56 56
57 // IPC::AttachmentBroker overrides. 57 // IPC::AttachmentBroker overrides.
58 bool SendAttachmentToProcess(BrokerableAttachment* attachment, 58 bool SendAttachmentToProcess(
59 base::ProcessId destination_process) override; 59 const scoped_refptr<IPC::BrokerableAttachment>& attachment,
60 base::ProcessId destination_process) override;
60 61
61 // IPC::Listener overrides. 62 // IPC::Listener overrides.
62 bool OnMessageReceived(const Message& message) override; 63 bool OnMessageReceived(const Message& message) override;
63 64
64 private: 65 private:
65 FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerPrivilegedMacMultiProcessTest, 66 FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerPrivilegedMacMultiProcessTest,
66 InsertRight); 67 InsertRight);
67 FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerPrivilegedMacMultiProcessTest, 68 FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerPrivilegedMacMultiProcessTest,
68 InsertSameRightTwice); 69 InsertSameRightTwice);
69 FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerPrivilegedMacMultiProcessTest, 70 FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerPrivilegedMacMultiProcessTest,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 125
125 // The port provider must live at least as long as the AttachmentBroker. 126 // The port provider must live at least as long as the AttachmentBroker.
126 base::PortProvider* port_provider_; 127 base::PortProvider* port_provider_;
127 128
128 DISALLOW_COPY_AND_ASSIGN(AttachmentBrokerPrivilegedMac); 129 DISALLOW_COPY_AND_ASSIGN(AttachmentBrokerPrivilegedMac);
129 }; 130 };
130 131
131 } // namespace IPC 132 } // namespace IPC
132 133
133 #endif // IPC_ATTACHMENT_BROKER_PRIVILEGED_MAC_H_ 134 #endif // IPC_ATTACHMENT_BROKER_PRIVILEGED_MAC_H_
OLDNEW
« no previous file with comments | « ipc/attachment_broker_mac_unittest.cc ('k') | ipc/attachment_broker_privileged_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698