IPC: Remove unnecessary conversions of BrokerableAttachment.

ipc/ipc_message.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_message.h"
 
 #include <limits.h>
 
 #include "base/atomic_sequence_num.h"
 #include "base/logging.h"
@@ skipping 129 matching lines @@
 #endif
 
 Message::NextMessageInfo::NextMessageInfo()
     : message_size(0), message_found(false), pickle_end(nullptr),
       message_end(nullptr) {}
 Message::NextMessageInfo::~NextMessageInfo() {}
 
 Message::SerializedAttachmentIds
 Message::SerializedIdsOfBrokerableAttachments() {
   DCHECK(HasBrokerableAttachments());
-  std::vector<BrokerableAttachment*> attachments =
-      attachment_set_->GetBrokerableAttachments();
+  std::vector<scoped_refptr<IPC::BrokerableAttachment>> attachments(

[Tom Sepez, 2015/10/29 19:12:51]

and here too

+      attachment_set_->GetBrokerableAttachments());
   CHECK_LE(attachments.size(), std::numeric_limits<size_t>::max() /
                                    BrokerableAttachment::kNonceSize);
   size_t size = attachments.size() * BrokerableAttachment::kNonceSize;
   char* buffer = static_cast<char*>(malloc(size));
   for (size_t i = 0; i < attachments.size(); ++i) {
-    const BrokerableAttachment* attachment = attachments[i];
     char* start_range = buffer + i * BrokerableAttachment::kNonceSize;
-    BrokerableAttachment::AttachmentId id = attachment->GetIdentifier();
+    BrokerableAttachment::AttachmentId id = attachments[i]->GetIdentifier();
     id.SerializeToBuffer(start_range, BrokerableAttachment::kNonceSize);
   }
   SerializedAttachmentIds ids;
   ids.buffer = buffer;
   ids.size = size;
   return ids;
 }
 
 // static
 void Message::FindNext(const char* range_start,
@@ skipping 120 matching lines @@
 bool Message::HasMojoHandles() const {
   return attachment_set_.get() && attachment_set_->num_mojo_handles() > 0;
 }
 
 bool Message::HasBrokerableAttachments() const {
   return attachment_set_.get() &&
          attachment_set_->num_brokerable_attachments() > 0;
 }
 
 }  // namespace IPC