Always call LayerImpl::SetDebugInfo in debug builds.

Always call LayerImpl::SetDebugInfo in debug builds.

This makes debugging easier. :)

Committed: https://crrev.com/b7e166f0dba00d2c9737d2ece0d7b22976506de2
Cr-Commit-Position: refs/heads/master@{#354927}
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3e813bde59f561782138f60ed4112ed61f8a7c89
Cr-Commit-Position: refs/heads/master@{#355201}

[skobes, 2015-10-19 22:46:51]

Description was changed from

==========
Always call LayerImpl::SetDebugInfo in debug builds.

This makes debugging easier. :)
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Always call LayerImpl::SetDebugInfo in debug builds.

This makes debugging easier. :)
==========

[skobes, 2015-10-19 22:47:02]

skobes@chromium.org changed reviewers:
+ enne@chromium.org

[skobes, 2015-10-19 22:47:03]

WDYT?

[enne (OOO), 2015-10-19 23:04:15]

lgtm

[skobes, 2015-10-19 23:05:17]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2015-10-19 23:05:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414503005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414503005/1

[commit-bot: I haz the power, 2015-10-20 00:17:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-20 00:17:53]

Patchset 1 (id:??) landed as
https://crrev.com/b7e166f0dba00d2c9737d2ece0d7b22976506de2
Cr-Commit-Position: refs/heads/master@{#354927}

[ajuma, 2015-10-20 14:45:25]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1413363002/ by ajuma@chromium.org.

The reason for reverting is: This broke ContextLost.WebGLContextLostInHiddenTab
in context_lost_tests on the GPU debug bots. e.g.:
http://build.chromium.org/p/chromium.gpu/builders/Linux%20Debug%20%28NVIDIA%2...
http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds...
http://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Debug%20%28AT...

Verified locally that reverting this fixes the test..

[skobes, 2015-10-20 22:40:01]

Description was changed from

==========
Always call LayerImpl::SetDebugInfo in debug builds.

This makes debugging easier. :)

Committed: https://crrev.com/b7e166f0dba00d2c9737d2ece0d7b22976506de2
Cr-Commit-Position: refs/heads/master@{#354927}
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Always call LayerImpl::SetDebugInfo in debug builds.

This makes debugging easier. :)

Committed: https://crrev.com/b7e166f0dba00d2c9737d2ece0d7b22976506de2
Cr-Commit-Position: refs/heads/master@{#354927}
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[skobes, 2015-10-21 00:00:54]

PTAL

[enne (OOO), 2015-10-21 00:04:12]

lgtm

https://codereview.chromium.org/1414503005/diff/20001/cc/blink/web_layer_impl.cc
File cc/blink/web_layer_impl.cc (right):

https://codereview.chromium.org/1414503005/diff/20001/cc/blink/web_layer_impl...
cc/blink/web_layer_impl.cc:70: layer_->SetLayerClient(nullptr);
Oh! Kind of surprised this managed to not be here before.

[skobes, 2015-10-21 00:14:40]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2015-10-21 00:15:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414503005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414503005/20001

[commit-bot: I haz the power, 2015-10-21 00:22:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-21 00:23:50]

Patchset 2 (id:??) landed as
https://crrev.com/3e813bde59f561782138f60ed4112ed61f8a7c89
Cr-Commit-Position: refs/heads/master@{#355201}