Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1414503005: Always call LayerImpl::SetDebugInfo in debug builds. (Closed)

Created:
5 years, 2 months ago by skobes
Modified:
5 years, 2 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always call LayerImpl::SetDebugInfo in debug builds. This makes debugging easier. :) Committed: https://crrev.com/b7e166f0dba00d2c9737d2ece0d7b22976506de2 Cr-Commit-Position: refs/heads/master@{#354927} CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3e813bde59f561782138f60ed4112ed61f8a7c89 Cr-Commit-Position: refs/heads/master@{#355201}

Patch Set 1 #

Patch Set 2 : fix crash in gpu test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M cc/blink/web_layer_impl.cc View 1 1 chunk +1 line, -0 lines 1 comment Download
M cc/layers/layer.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
skobes
WDYT?
5 years, 2 months ago (2015-10-19 22:47:03 UTC) #3
enne (OOO)
5 years, 2 months ago (2015-10-19 23:04:12 UTC) #4
enne (OOO)
lgtm
5 years, 2 months ago (2015-10-19 23:04:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503005/1
5 years, 2 months ago (2015-10-19 23:05:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 00:17:08 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7e166f0dba00d2c9737d2ece0d7b22976506de2 Cr-Commit-Position: refs/heads/master@{#354927}
5 years, 2 months ago (2015-10-20 00:17:53 UTC) #9
ajuma
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1413363002/ by ajuma@chromium.org. ...
5 years, 2 months ago (2015-10-20 14:45:25 UTC) #10
skobes
PTAL
5 years, 2 months ago (2015-10-21 00:00:54 UTC) #12
enne (OOO)
lgtm https://codereview.chromium.org/1414503005/diff/20001/cc/blink/web_layer_impl.cc File cc/blink/web_layer_impl.cc (right): https://codereview.chromium.org/1414503005/diff/20001/cc/blink/web_layer_impl.cc#newcode70 cc/blink/web_layer_impl.cc:70: layer_->SetLayerClient(nullptr); Oh! Kind of surprised this managed to ...
5 years, 2 months ago (2015-10-21 00:04:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503005/20001
5 years, 2 months ago (2015-10-21 00:15:54 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-21 00:22:24 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 00:23:50 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e813bde59f561782138f60ed4112ed61f8a7c89
Cr-Commit-Position: refs/heads/master@{#355201}

Powered by Google App Engine
This is Rietveld 408576698