Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1414503003: Add SkTTopoSort (Closed)

Created:
5 years, 2 months ago by robertphillips
Modified:
5 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 6

Patch Set 3 : Address code review comments #

Patch Set 4 : Misc clean up #

Patch Set 5 : Fix debug function naming #

Patch Set 6 : Fixed comment format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -0 lines) Patch
A bench/TopoSortBench.cpp View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
M gyp/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkTTopoSort.h View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
A tests/TopoSortTest.cpp View 1 2 3 4 5 1 chunk +142 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.h View 1 2 3 4 2 chunks +92 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
robertphillips
5 years, 2 months ago (2015-10-17 21:08:26 UTC) #2
bsalomon
Seems like a nice design. Some Qs inline. https://codereview.chromium.org/1414503003/diff/20001/src/core/SkTTopoSort.h File src/core/SkTTopoSort.h (right): https://codereview.chromium.org/1414503003/diff/20001/src/core/SkTTopoSort.h#newcode64 src/core/SkTTopoSort.h:64: template ...
5 years, 2 months ago (2015-10-19 14:19:14 UTC) #3
robertphillips
https://codereview.chromium.org/1414503003/diff/20001/src/core/SkTTopoSort.h File src/core/SkTTopoSort.h (right): https://codereview.chromium.org/1414503003/diff/20001/src/core/SkTTopoSort.h#newcode64 src/core/SkTTopoSort.h:64: template <typename T, typename Traits = T> On 2015/10/19 ...
5 years, 2 months ago (2015-10-19 16:21:07 UTC) #4
mtklein
> Done - although we might want to create a top-level utils directory sometime for ...
5 years, 2 months ago (2015-10-19 16:40:05 UTC) #5
bsalomon
lgtm
5 years, 2 months ago (2015-10-19 18:27:18 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503003/80001
5 years, 2 months ago (2015-10-19 18:28:57 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/2055) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on ...
5 years, 2 months ago (2015-10-19 18:29:59 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503003/100001
5 years, 2 months ago (2015-10-19 18:45:16 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-19 18:54:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414503003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414503003/100001
5 years, 2 months ago (2015-10-19 19:15:20 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 19:15:58 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/423f6461e98ba28730d05e5894804a4970a09bde

Powered by Google App Engine
This is Rietveld 408576698