Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issue 1414493004: [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut (Closed)

Created:
5 years, 1 month ago by radu.velea
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: Make software and SSE bit exact? BUG=532910 Committed: https://crrev.com/6d61b828235d2a7b675bb3c97a35ff3e81199c55 Cr-Commit-Position: refs/heads/master@{#358581}

Patch Set 1 #

Total comments: 2

Patch Set 2 : WebKit whitespace #

Patch Set 3 : Updated tests #

Patch Set 4 : Used rounding instead of trunc. Updated tests for manual rebaseline #

Patch Set 5 : #

Total comments: 3

Patch Set 6 : Added bug ID to tests #

Patch Set 7 : #

Patch Set 8 : Rebase & temp. comment Layout Test #

Patch Set 9 : Update README #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 2 chunks +125 lines, -1 line 0 comments Download
M third_party/qcms/README.chromium View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/src/transform-sse2.c View 1 2 3 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 58 (28 generated)
Noel Gordon
> Software and SSE versions are now bit-exact. Good work.
5 years, 1 month ago (2015-11-04 12:58:08 UTC) #3
Noel Gordon
https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transform-sse2.c File third_party/qcms/src/transform-sse2.c (right): https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transform-sse2.c#newcode233 third_party/qcms/src/transform-sse2.c:233: _mm_store_si128((__m128i*)output, _mm_cvttps_epi32(result)); Now we match the s/w case, one ...
5 years, 1 month ago (2015-11-04 13:01:28 UTC) #4
radu.velea
https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transform-sse2.c File third_party/qcms/src/transform-sse2.c (right): https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transform-sse2.c#newcode233 third_party/qcms/src/transform-sse2.c:233: _mm_store_si128((__m128i*)output, _mm_cvttps_epi32(result)); On 2015/11/04 13:01:28, noel gordon wrote: > ...
5 years, 1 month ago (2015-11-04 13:12:19 UTC) #5
radu.velea
On 2015/11/04 13:12:19, radu.velea wrote: > https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transform-sse2.c > File third_party/qcms/src/transform-sse2.c (right): > > https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transform-sse2.c#newcode233 > ...
5 years, 1 month ago (2015-11-04 13:14:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/20001
5 years, 1 month ago (2015-11-04 14:24:24 UTC) #8
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 1 month ago (2015-11-04 14:24:26 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/20001
5 years, 1 month ago (2015-11-04 14:41:28 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/130177)
5 years, 1 month ago (2015-11-04 15:33:58 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/20001
5 years, 1 month ago (2015-11-05 23:36:23 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/131192)
5 years, 1 month ago (2015-11-06 00:52:23 UTC) #19
Noel Gordon
From patch set #2 try jobs: the tests needing rebaselines over all ports that run ...
5 years, 1 month ago (2015-11-06 01:57:07 UTC) #20
Noel Gordon
https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/LayoutTests/TestExpectations#newcode763 third_party/WebKit/LayoutTests/TestExpectations:763: compositing/color-matching/image-color-matching.html [ NeedsManualRebaseline ] NeedsManualRebaseline -> NeedsRebaseline everywhere and ...
5 years, 1 month ago (2015-11-06 14:01:10 UTC) #21
radu.velea
https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/LayoutTests/TestExpectations#newcode763 third_party/WebKit/LayoutTests/TestExpectations:763: compositing/color-matching/image-color-matching.html [ NeedsManualRebaseline ] On 2015/11/06 14:01:10, noel gordon ...
5 years, 1 month ago (2015-11-06 14:20:51 UTC) #22
Noel Gordon
ok, let's do a dry run.
5 years, 1 month ago (2015-11-06 14:22:27 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/120001
5 years, 1 month ago (2015-11-06 14:22:47 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/120001
5 years, 1 month ago (2015-11-06 14:23:36 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/116286)
5 years, 1 month ago (2015-11-06 14:31:09 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/140001
5 years, 1 month ago (2015-11-06 14:59:50 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/10538)
5 years, 1 month ago (2015-11-06 15:16:05 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/140001
5 years, 1 month ago (2015-11-06 15:20:11 UTC) #42
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 16:11:00 UTC) #44
Noel Gordon
From the trys that run webkit tests, 121 tests would need a rebaseline with the ...
5 years, 1 month ago (2015-11-09 03:12:09 UTC) #45
Noel Gordon
LGTM
5 years, 1 month ago (2015-11-09 10:15:41 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/160001
5 years, 1 month ago (2015-11-09 10:15:56 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/137829)
5 years, 1 month ago (2015-11-09 10:17:12 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/180001
5 years, 1 month ago (2015-11-09 11:34:40 UTC) #54
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years, 1 month ago (2015-11-09 12:30:15 UTC) #55
commit-bot: I haz the power
Patchset 10 (id:??) landed as https://crrev.com/6d61b828235d2a7b675bb3c97a35ff3e81199c55 Cr-Commit-Position: refs/heads/master@{#358581}
5 years, 1 month ago (2015-11-09 12:31:18 UTC) #56
leviw_travelin_and_unemployed
On 2015/11/09 at 12:31:18, commit-bot wrote: > Patchset 10 (id:??) landed as https://crrev.com/6d61b828235d2a7b675bb3c97a35ff3e81199c55 > Cr-Commit-Position: ...
5 years, 1 month ago (2015-11-09 18:34:47 UTC) #57
Noel Gordon
5 years, 1 month ago (2015-11-09 22:59:40 UTC) #58
Message was sent while issue was closed.
> Looks like they may still just need to be rebaselined?

https://codereview.chromium.org/1432933002

Powered by Google App Engine
This is Rietveld 408576698