|
|
Created:
5 years, 1 month ago by radu.velea Modified:
5 years, 1 month ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut
Before this CL:
Input profile sRGB IEC61966-2.1
Output profile Adobe RGB (1998) (using qcms precache)
RMS color error 2.66
Input profile Adobe RGB (1998)
Output profile sRGB IEC61966-2.1 (using qcms precache)
RMS color error 0.94
After this CL:
Input profile sRGB IEC61966-2.1
Output profile Adobe RGB (1998) (using qcms precache)
RMS color error 2.66
Input profile Adobe RGB (1998)
Output profile sRGB IEC61966-2.1 (using qcms precache)
RMS color error 0.87
TODO: Make software and SSE bit exact?
BUG=532910
Committed: https://crrev.com/6d61b828235d2a7b675bb3c97a35ff3e81199c55
Cr-Commit-Position: refs/heads/master@{#358581}
Patch Set 1 #
Total comments: 2
Patch Set 2 : WebKit whitespace #Patch Set 3 : Updated tests #Patch Set 4 : Used rounding instead of trunc. Updated tests for manual rebaseline #Patch Set 5 : #
Total comments: 3
Patch Set 6 : Added bug ID to tests #Patch Set 7 : #Patch Set 8 : Rebase & temp. comment Layout Test #Patch Set 9 : Update README #Patch Set 10 : #
Messages
Total messages: 58 (28 generated)
Description was changed from ========== Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut BUG=532910 ========== to ========== Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.68 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.84 Software and SSE versions are now bit-exact. BUG=532910 ==========
radu.velea@intel.com changed reviewers: + noel@chromium.org
> Software and SSE versions are now bit-exact. Good work.
https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transf... File third_party/qcms/src/transform-sse2.c (right): https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transf... third_party/qcms/src/transform-sse2.c:233: _mm_store_si128((__m128i*)output, _mm_cvttps_epi32(result)); Now we match the s/w case, one question: if you rounded here, would that reduce the RMS error?
https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transf... File third_party/qcms/src/transform-sse2.c (right): https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transf... third_party/qcms/src/transform-sse2.c:233: _mm_store_si128((__m128i*)output, _mm_cvttps_epi32(result)); On 2015/11/04 13:01:28, noel gordon wrote: > Now we match the s/w case, one question: if you rounded here, would that reduce > the RMS error? Using SSE round (_mm_cvtps_epi32) generates the following output for SSE code: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87
On 2015/11/04 13:12:19, radu.velea wrote: > https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transf... > File third_party/qcms/src/transform-sse2.c (right): > > https://codereview.chromium.org/1414493004/diff/1/third_party/qcms/src/transf... > third_party/qcms/src/transform-sse2.c:233: _mm_store_si128((__m128i*)output, > _mm_cvttps_epi32(result)); > On 2015/11/04 13:01:28, noel gordon wrote: > > Now we match the s/w case, one question: if you rounded here, would that > reduce > > the RMS error? > > Using SSE round (_mm_cvtps_epi32) generates the following output for SSE code: > > Input profile sRGB IEC61966-2.1 > Output profile Adobe RGB (1998) (using qcms precache) > RMS color error 2.66 > > Input profile Adobe RGB (1998) > Output profile sRGB IEC61966-2.1 (using qcms precache) > RMS color error 0.87 non-SSE code generates same RMS with rounding using roundf.
The CQ bit was checked by radu.velea@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.68 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.84 Software and SSE versions are now bit-exact. BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.68 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.84 Software and SSE versions are now bit-exact. BUG=532910 ==========
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
From patch set #2 try jobs: the tests needing rebaselines over all ports that run the layout tests seem to be: compositing/color-matching/image-color-matching.html compositing/masks/direct-image-mask.html compositing/reflections/simple-composited-reflections.html compositing/visibility/visibility-image-layers.html css2.1/20110323/floating-replaced-height-008.htm css2.1/20110323/inline-block-replaced-height-008.htm css2.1/20110323/inline-replaced-height-008.htm css3/blending/background-blend-mode-crossfade-image-gradient.html css3/blending/background-blend-mode-default-value.html css3/blending/background-blend-mode-different-image-formats.html css3/blending/background-blend-mode-gradient-image.html css3/blending/background-blend-mode-image-color.html css3/blending/background-blend-mode-image-image.html css3/blending/background-blend-mode-image-svg.html css3/blending/background-blend-mode-multiple-background-layers.html css3/blending/background-blend-mode-opaque-layer.html css3/blending/background-blend-mode-separate-layer-declaration.html css3/blending/background-blend-mode-single-layer-no-blending.html css3/blending/background-blend-mode-tiled-gradient.html css3/blending/effect-background-blend-mode.html css3/blending/effect-background-blend-mode-stacking.html css3/blending/effect-background-blend-mode-tiled.html css3/blending/mix-blend-mode-isolated-group-1.html css3/blending/mix-blend-mode-isolated-group-2.html css3/blending/mix-blend-mode-isolated-group-3.html css3/filters/buffer-offset.html css3/filters/composited-reflected.html css3/filters/crash-filter-change.html css3/filters/effect-blur.html css3/filters/effect-blur-hw.html css3/filters/effect-brightness.html css3/filters/effect-brightness-clamping.html css3/filters/effect-brightness-clamping-hw.html css3/filters/effect-brightness-hw.html css3/filters/effect-combined.html css3/filters/effect-combined-hw.html css3/filters/effect-contrast.html css3/filters/effect-contrast-hw.html css3/filters/effect-drop-shadow.html css3/filters/effect-drop-shadow-hw.html css3/filters/effect-grayscale.html css3/filters/effect-grayscale-hw.html css3/filters/effect-hue-rotate.html css3/filters/effect-hue-rotate-hw.html css3/filters/effect-invert.html css3/filters/effect-invert-hw.html css3/filters/effect-opacity.html css3/filters/effect-opacity-hw.html css3/filters/effect-reference.html css3/filters/effect-reference-colorspace-hw.html css3/filters/effect-reference-composite.html css3/filters/effect-reference-composite-hw.html css3/filters/effect-reference-external.html css3/filters/effect-reference-hidpi.html css3/filters/effect-reference-hidpi-hw.html css3/filters/effect-reference-hw.html css3/filters/effect-reference-ordering.html css3/filters/effect-reference-ordering-hw.html css3/filters/effect-reference-subregion.html css3/filters/effect-reference-subregion-chained.html css3/filters/effect-reference-subregion-chained-hw.html css3/filters/effect-reference-subregion-colormatrix.html css3/filters/effect-reference-subregion-hw.html css3/filters/effect-reference-tile.html css3/filters/effect-reference-tile-hw.html css3/filters/effect-reference-zoom.html css3/filters/effect-reference-zoom-hw.html css3/filters/effect-saturate.html css3/filters/effect-saturate-hw.html css3/filters/effect-sepia.html css3/filters/effect-sepia-hw.html css3/filters/regions-expanding.html css3/images/cross-fade-background-size.html fast/borders/border-image-omit-right-slice.html fast/canvas/canvas-toBlob-jpeg-maximum-quality.html fast/canvas/canvas-toBlob-jpeg-medium-quality.html fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html fast/css/background-shorthand-invalid-url.html fast/images/color-jpeg-with-color-profile.html fast/images/embed-image.html fast/images/jpeg-with-color-profile.html fast/images/object-image.html fast/images/paletted-png-with-color-profile.html fast/images/png-color-profile-ignore-gamma.html fast/images/png-with-color-profile.html fast/images/webp-color-profile-lossless.html fast/images/webp-color-profile-lossy.html fast/images/webp-color-profile-lossy-alpha.html fast/inline/inline-box-background-long-image.html fast/reflections/reflection-direction.html fast/reflections/reflection-masks.html fast/reflections/reflection-masks-opacity.html fast/reflections/reflection-masks-outset.html fast/reflections/reflection-with-zoom.html fast/repaint/background-image-paint-invalidation-large-abspos-div.html fast/repaint/background-image-paint-invalidation-small-document.html fast/writing-mode/block-level-images.html ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images.htm ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box.htm ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box.htm ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm ietestcenter/css3/bordersbackgrounds/background-color-border-box.htm ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box.htm ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio.htm ietestcenter/css3/bordersbackgrounds/none-as-image-layer.htm scrollbars/listbox-scrollbar-combinations.html scrollbars/overflow-scrollbar-combinations.html svg/as-border-image/svg-as-border-image.html svg/as-border-image/svg-as-border-image-2.html svg/custom/createImageElement.svg svg/custom/createImageElement2.xhtml svg/custom/focus-ring.svg svg/custom/group-opacity.svg svg/custom/image-parent-translation.xhtml svg/custom/image-small-width-height.svg svg/custom/image-with-transform-clip-filter.svg svg/custom/js-update-image.svg svg/custom/js-update-image-and-display.svg svg/custom/js-update-image-and-display2.svg svg/custom/js-update-image-and-display3.svg svg/custom/pointer-events-image.svg svg/custom/pointer-events-image-css-transform.svg svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html svg/custom/text-image-opacity.svg svg/custom/transformed-outlines.svg svg/custom/use-on-g-containing-foreignObject-and-image.svg svg/dynamic-updates/SVGImageElement-dom-height-attr.html svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html svg/dynamic-updates/SVGImageElement-dom-width-attr.html svg/dynamic-updates/SVGImageElement-dom-x-attr.html svg/dynamic-updates/SVGImageElement-dom-y-attr.html svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html svg/filters/feImage-subregions.svg svg/filters/feImage-subregions-preseveAspectRatio-none.svg svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox.svg svg/filters/filter-source-position.svg svg/repaint/image-href-change.svg svg/W3C-SVG-1.1/struct-image-04-t.svg svg/W3C-SVG-1.1/struct-image-08-t.svg svg/zoom/page/zoom-background-images.html svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml tables/mozilla/bugs/bug82946-2.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-jpeg-maximum-quality.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-jpeg-medium-quality.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-webp-maximum-quality.html virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html virtual/gpu/fast/canvas/canvas-toBlob-jpeg-maximum-quality.html virtual/gpu/fast/canvas/canvas-toBlob-jpeg-medium-quality.html virtual/gpu/fast/canvas/canvas-toBlob-webp-maximum-quality.html virtual/gpu/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html virtual/prefer_compositing_to_lcd_text/scrollbars/listbox-scrollbar-combinations.html virtual/prefer_compositing_to_lcd_text/scrollbars/overflow-scrollbar-combinations.html virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations.html virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations.html virtual/syncpaint/fast/repaint/background-image-paint-invalidation-large-abspos-div.html virtual/syncpaint/fast/repaint/background-image-paint-invalidation-small-document.html virtual/threaded/compositing/visibility/visibility-image-layers.html
https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:763: compositing/color-matching/image-color-matching.html [ NeedsManualRebaseline ] NeedsManualRebaseline -> NeedsRebaseline everywhere and prefix each test with your bug number, so crbug.com/532910 compositing/color-matching/image-color-matching.html [ NeedsRebaseline ] crbug.com/532910 compositing/masks/direct-image-mask.html [ NeedsRebaseline ] ... etc.
https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:763: compositing/color-matching/image-color-matching.html [ NeedsManualRebaseline ] On 2015/11/06 14:01:10, noel gordon wrote: > NeedsManualRebaseline -> NeedsRebaseline everywhere and prefix each test with > your bug number, so > > crbug.com/532910 compositing/color-matching/image-color-matching.html [ > NeedsRebaseline ] > crbug.com/532910 compositing/masks/direct-image-mask.html [ NeedsRebaseline ] > ... > > etc. Done. https://codereview.chromium.org/1414493004/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:763: compositing/color-matching/image-color-matching.html [ NeedsManualRebaseline ] On 2015/11/06 14:01:10, noel gordon wrote: > NeedsManualRebaseline -> NeedsRebaseline everywhere and prefix each test with > your bug number, so > > crbug.com/532910 compositing/color-matching/image-color-matching.html [ > NeedsRebaseline ] > crbug.com/532910 compositing/masks/direct-image-mask.html [ NeedsRebaseline ] > ... > > etc. Done.
ok, let's do a dry run.
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/120001
The CQ bit was unchecked by noel@chromium.org
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/120001
Description was changed from ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.68 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.84 Software and SSE versions are now bit-exact. BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 Software and SSE versions are now bit-exact. BUG=532910 ==========
Description was changed from ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 Software and SSE versions are now bit-exact. BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 BUG=532910 ==========
Description was changed from ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: make software and SSE bit exact BUG=532910 ==========
Description was changed from ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: make software and SSE bit exact BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: make software and SSE bit exact? BUG=532910 ==========
Description was changed from ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: make software and SSE bit exact? BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: Make software and SSE bit exact? BUG=532910 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: Make software and SSE bit exact? BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: Make software and SSE bit exact? Fix README. BUG=532910 ==========
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
From the trys that run webkit tests, 121 tests would need a rebaseline with the rounding change c.f. 164 tests with the trunc change. Just recording the affected tests I computed here for reference. compositing/color-matching/image-color-matching.html compositing/masks/direct-image-mask.html compositing/reflections/simple-composited-reflections.html compositing/visibility/visibility-image-layers.html css3/blending/background-blend-mode-crossfade-image-gradient.html css3/blending/background-blend-mode-default-value.html css3/blending/background-blend-mode-different-image-formats.html css3/blending/background-blend-mode-gradient-image.html css3/blending/background-blend-mode-image-color.html css3/blending/background-blend-mode-image-image.html css3/blending/background-blend-mode-image-svg.html css3/blending/background-blend-mode-multiple-background-layers.html css3/blending/background-blend-mode-opaque-layer.html css3/blending/background-blend-mode-separate-layer-declaration.html css3/blending/background-blend-mode-single-layer-no-blending.html css3/blending/background-blend-mode-tiled-gradient.html css3/blending/effect-background-blend-mode.html css3/blending/effect-background-blend-mode-stacking.html css3/blending/effect-background-blend-mode-tiled.html css3/blending/mix-blend-mode-isolated-group-1.html css3/blending/mix-blend-mode-isolated-group-2.html css3/blending/mix-blend-mode-isolated-group-3.html css3/filters/buffer-offset.html css3/filters/composited-reflected.html css3/filters/crash-filter-change.html css3/filters/effect-blur.html css3/filters/effect-blur-hw.html css3/filters/effect-brightness.html css3/filters/effect-brightness-clamping.html css3/filters/effect-brightness-clamping-hw.html css3/filters/effect-brightness-hw.html css3/filters/effect-combined.html css3/filters/effect-combined-hw.html css3/filters/effect-contrast.html css3/filters/effect-contrast-hw.html css3/filters/effect-drop-shadow.html css3/filters/effect-drop-shadow-hw.html css3/filters/effect-grayscale.html css3/filters/effect-grayscale-hw.html css3/filters/effect-hue-rotate.html css3/filters/effect-hue-rotate-hw.html css3/filters/effect-invert.html css3/filters/effect-invert-hw.html css3/filters/effect-opacity.html css3/filters/effect-opacity-hw.html css3/filters/effect-reference.html css3/filters/effect-reference-colorspace.html css3/filters/effect-reference-colorspace-hw.html css3/filters/effect-reference-composite.html css3/filters/effect-reference-composite-hw.html css3/filters/effect-reference-external.html css3/filters/effect-reference-hidpi.html css3/filters/effect-reference-hidpi-hw.html css3/filters/effect-reference-hw.html css3/filters/effect-reference-ordering.html css3/filters/effect-reference-ordering-hw.html css3/filters/effect-reference-subregion.html css3/filters/effect-reference-subregion-chained.html css3/filters/effect-reference-subregion-chained-hw.html css3/filters/effect-reference-subregion-colormatrix.html css3/filters/effect-reference-subregion-hw.html css3/filters/effect-reference-zoom.html css3/filters/effect-reference-zoom-hw.html css3/filters/effect-saturate.html css3/filters/effect-saturate-hw.html css3/filters/effect-sepia.html css3/filters/effect-sepia-hw.html css3/filters/regions-expanding.html css3/images/cross-fade-background-size.html fast/canvas/canvas-toBlob-jpeg-maximum-quality.html fast/canvas/canvas-toBlob-jpeg-medium-quality.html fast/canvas/canvas-toBlob-webp-maximum-quality.html fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html fast/css/background-shorthand-invalid-url.html fast/images/color-jpeg-with-color-profile.html fast/images/jpeg-with-color-profile.html fast/images/paletted-png-with-color-profile.html fast/images/png-with-color-profile.html fast/images/webp-color-profile-lossless.html fast/images/webp-color-profile-lossy.html fast/images/webp-color-profile-lossy-alpha.html fast/inline/inline-box-background-long-image.html fast/reflections/reflection-direction.html fast/reflections/reflection-masks.html fast/reflections/reflection-masks-opacity.html fast/reflections/reflection-masks-outset.html fast/reflections/reflection-with-zoom.html fast/repaint/background-image-paint-invalidation-large-abspos-div.html fast/repaint/background-image-paint-invalidation-small-document.html ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box.htm ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio.htm scrollbars/listbox-scrollbar-combinations.html scrollbars/overflow-scrollbar-combinations.html svg/custom/group-opacity.svg svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html svg/filters/filter-source-position.svg svg/repaint/image-href-change.svg svg/W3C-SVG-1.1/struct-image-04-t.svg svg/W3C-SVG-1.1/struct-image-08-t.svg svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml tables/mozilla/bugs/bug82946-2.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-jpeg-maximum-quality.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-jpeg-medium-quality.html virtual/display_list_2d_canvas/fast/canvas/canvas-toBlob-webp-maximum-quality.html virtual/display_list_2d_canvas/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html virtual/gpu/fast/canvas/canvas-toBlob-jpeg-maximum-quality.html virtual/gpu/fast/canvas/canvas-toBlob-jpeg-medium-quality.html virtual/gpu/fast/canvas/canvas-toBlob-webp-maximum-quality.html virtual/gpu/fast/canvas/canvas-toDataURL-jpeg-maximum-quality.html virtual/prefer_compositing_to_lcd_text/scrollbars/listbox-scrollbar-combinations.html virtual/prefer_compositing_to_lcd_text/scrollbars/overflow-scrollbar-combinations.html virtual/rootlayerscrolls/scrollbars/listbox-scrollbar-combinations.html virtual/rootlayerscrolls/scrollbars/overflow-scrollbar-combinations.html virtual/syncpaint/fast/repaint/background-image-paint-invalidation-large-abspos-div.html virtual/syncpaint/fast/repaint/background-image-paint-invalidation-small-document.html virtual/syncpaint/inspector/tracing/console-timeline.html virtual/syncpaint/inspector/tracing/timeline-style-recalc-all-invalidator-types.html virtual/threaded/compositing/visibility/visibility-image-layers.html
Description was changed from ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: Make software and SSE bit exact? Fix README. BUG=532910 ========== to ========== [qcms] Reduce RMS color error for qcms_transform_data_rgb(a)_out_lut Before this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.94 After this CL: Input profile sRGB IEC61966-2.1 Output profile Adobe RGB (1998) (using qcms precache) RMS color error 2.66 Input profile Adobe RGB (1998) Output profile sRGB IEC61966-2.1 (using qcms precache) RMS color error 0.87 TODO: Make software and SSE bit exact? BUG=532910 ==========
LGTM
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/160001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by radu.velea@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from noel@chromium.org Link to the patchset: https://codereview.chromium.org/1414493004/#ps180001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414493004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414493004/180001
Message was sent while issue was closed.
Committed patchset #10 (id:180001)
Message was sent while issue was closed.
Patchset 10 (id:??) landed as https://crrev.com/6d61b828235d2a7b675bb3c97a35ff3e81199c55 Cr-Commit-Position: refs/heads/master@{#358581}
Message was sent while issue was closed.
On 2015/11/09 at 12:31:18, commit-bot wrote: > Patchset 10 (id:??) landed as https://crrev.com/6d61b828235d2a7b675bb3c97a35ff3e81199c55 > Cr-Commit-Position: refs/heads/master@{#358581} There are a bunch of tests failing after these test expectations went in, I'm not sure why: https://sheriff-o-matic.appspot.com/blink/failure/webkit_tests%3A%3Ascrollbar... https://sheriff-o-matic.appspot.com/blink/failure/webkit_tests%3A%3Ascrollbar... Looks like they may still just need to be rebaselined?
Message was sent while issue was closed.
> Looks like they may still just need to be rebaselined? https://codereview.chromium.org/1432933002 |