runtime/lib/integers.cc - Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/integers.cc

Issue 1414493003: Remove some Isolate::current_zone() calls, as it gets the zone from mutator thread not the current … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Zones and commentw Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/integers.cc

diff --git a/runtime/lib/integers.cc b/runtime/lib/integers.cc

index e8d655ca416b741a98b559dfacaf451788bea44b..8deeee437b07c954136755346862d61097749d98 100644

--- a/runtime/lib/integers.cc

+++ b/runtime/lib/integers.cc

@@ -237,7 +237,7 @@ DEFINE_NATIVE_ENTRY(Integer_fromEnvironment, 3) {

GET_NATIVE_ARGUMENT(Integer, default_value, arguments->NativeArgAt(2));

// Call the embedder to supply us with the environment.

const String& env_value =

- String::Handle(Api::CallEnvironmentCallback(isolate, name));

+ String::Handle(Api::CallEnvironmentCallback(thread, name));

if (!env_value.IsNull()) {

const Integer& result = Integer::Handle(ParseInteger(env_value));

if (!result.IsNull()) {

« no previous file with comments | « runtime/lib/bool.cc ('k') | runtime/lib/string.cc » ('j') | no next file with comments »