ash/accelerators/accelerator_controller.h - Issue 1414483011: Deprecate Shift+Alt to switch IME and use Ctrl+Shift+Space instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/accelerator_controller.h

Issue 1414483011: Deprecate Shift+Alt to switch IME and use Ctrl+Shift+Space instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modified the design to account for deprecated accelerators that map to the same action. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/accelerators/accelerator_controller.h

diff --git a/ash/accelerators/accelerator_controller.h b/ash/accelerators/accelerator_controller.h

index 29c4760ce3168b5698f7dc86af4bb7d7ab1d2ea5..79cc67399a608731c0d2fb866aa304d3d1d4257b 100644

--- a/ash/accelerators/accelerator_controller.h

+++ b/ash/accelerators/accelerator_controller.h

@@ -133,6 +133,8 @@ class ASH_EXPORT AcceleratorController : public ui::AcceleratorTarget {

FRIEND_TEST_ALL_PREFIXES(AcceleratorControllerTest, GlobalAccelerators);

FRIEND_TEST_ALL_PREFIXES(AcceleratorControllerTest,

DontRepeatToggleFullscreen);

+ FRIEND_TEST_ALL_PREFIXES(DeprecatedAcceleratorTester,

+ TestDeprecatedAcceleratorsBehavior);

// Initializes the accelerators this class handles as a target.

void Init();

« no previous file with comments | « no previous file | ash/accelerators/accelerator_controller.cc » ('j') | chrome/browser/resources/chromeos/keyboard_overlay_data.js » ('J')