mojo/dart/test/bindings_generation_test.dart - Issue 1414483010: Dart: Use a RawReceivePort to receive events for Mojo handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/test/bindings_generation_test.dart

Issue 1414483010: Dart: Use a RawReceivePort to receive events for Mojo handles. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Merge Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/test/bindings_generation_test.dart

diff --git a/mojo/dart/test/bindings_generation_test.dart b/mojo/dart/test/bindings_generation_test.dart

index 71559f2be991f92847b8f07e28e7778b7ba4203c..9b9a7397606e09e0db26bdd509812023f03297d2 100644

--- a/mojo/dart/test/bindings_generation_test.dart

+++ b/mojo/dart/test/bindings_generation_test.dart

@@ -303,7 +303,7 @@ Future<bool> runOnClosedTest() {

var testCompleter = new Completer();

var pipe = new core.MojoMessagePipe();

var proxy = new sample.ProviderProxy.fromEndpoint(pipe.endpoints[0]);

- proxy.impl.onError = () => testCompleter.complete(true);

+ proxy.impl.onError = (_) => testCompleter.complete(true);

Isolate.spawn(closingProviderIsolate, pipe.endpoints[1]);

return testCompleter.future.then((b) {

Expect.isTrue(b);