src/DartARM32/assembler_arm.cc - Issue 1414483008: Add CMP(register) and CMP(Immediate) to ARM integerated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/DartARM32/assembler_arm.cc

Issue 1414483008: Add CMP(register) and CMP(Immediate) to ARM integerated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/DartARM32/assembler_arm.cc

diff --git a/src/DartARM32/assembler_arm.cc b/src/DartARM32/assembler_arm.cc

index cbf7a411e62f28bb78634af6c3a6a164a5b30a6f..180a182863ae58a11778e9c97df5ea3e87dc0907 100644

--- a/src/DartARM32/assembler_arm.cc

+++ b/src/DartARM32/assembler_arm.cc

@@ -266,9 +266,12 @@ void Assembler::teq(Register rn, Operand o, Condition cond) {

}

+#if 0

+// Moved to ARM32::AssemblerARM32::cmp()

void Assembler::cmp(Register rn, Operand o, Condition cond) {

EmitType01(cond, o.type(), CMP, 1, rn, R0, o);

}

+#endif

void Assembler::cmn(Register rn, Operand o, Condition cond) {

« no previous file with comments | « src/DartARM32/assembler_arm.h ('k') | src/IceAssemblerARM32.h » ('j') | no next file with comments »