components/password_manager/core/browser/password_manager_test_utils.cc - Issue 1414463004: Implement origin-based deletion for passwords in PasswordDefaultMac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_test_utils.cc

Issue 1414463004: Implement origin-based deletion for passwords in PasswordDefaultMac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Address first round of comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager_test_utils.h ('K') | « components/password_manager/core/browser/password_manager_test_utils.h ('k') | components/password_manager/core/browser/password_store_change.h » ('j') | components/password_manager/core/browser/password_store_default_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_test_utils.cc

diff --git a/components/password_manager/core/browser/password_manager_test_utils.cc b/components/password_manager/core/browser/password_manager_test_utils.cc

index 9613d23b87b765280e9449d2c57451f36bc91a5d..e920910bb75719113759f7e463cdac1aecdd32b8 100644

--- a/components/password_manager/core/browser/password_manager_test_utils.cc

+++ b/components/password_manager/core/browser/password_manager_test_utils.cc

@@ -94,4 +94,8 @@ bool ContainsEqualPasswordFormsUnordered(

return !had_mismatched_actual_form && remaining_expectations.empty();

}

+// Explicit out-of-line constructor/destructor required.

vasilii 2015/11/18 16:27:42 It's a style rule, no need for clarifications. Add

Timo Reimann 2015/11/18 23:42:15 Done.

+MockPasswordStoreObserver::MockPasswordStoreObserver() {}

+MockPasswordStoreObserver::~MockPasswordStoreObserver() {}

} // namespace password_manager