components/password_manager/core/browser/BUILD.gn - Issue 1414463004: Implement origin-based deletion for passwords in PasswordDefaultMac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/BUILD.gn

Issue 1414463004: Implement origin-based deletion for passwords in PasswordDefaultMac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Address first round of comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_mac_unittest.cc ('K') | « components/password_manager.gypi ('k') | components/password_manager/core/browser/password_manager_test_utils.h » ('j') | components/password_manager/core/browser/password_manager_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/BUILD.gn

diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn

index 40b453604cf57083a315b47af9fbed491606e370..deeca893e3a3b73eb5d02133a29bd24736401889 100644

--- a/components/password_manager/core/browser/BUILD.gn

+++ b/components/password_manager/core/browser/BUILD.gn

@@ -78,6 +78,7 @@ source_set("browser") {

"password_manager_util.h",

"password_store.cc",

"password_store.h",

+ "password_store_change.cc",

"password_store_change.h",

"password_store_consumer.cc",

"password_store_consumer.h",

@@ -199,6 +200,7 @@ source_set("unit_tests") {

"password_manager_unittest.cc",

"password_manager_util_unittest.cc",

"password_store_default_unittest.cc",

+ "password_store_origin_unittest.h",

"password_store_unittest.cc",

"password_syncable_service_unittest.cc",

"psl_matching_helper_unittest.cc",