chrome/browser/password_manager/password_store_proxy_mac.cc - Issue 1414463004: Implement origin-based deletion for passwords in PasswordDefaultMac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_proxy_mac.cc

Issue 1414463004: Implement origin-based deletion for passwords in PasswordDefaultMac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Address first round of comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_mac_unittest.cc ('K') | « chrome/browser/password_manager/password_store_proxy_mac.h ('k') | chrome/browser/password_manager/password_store_x_unittest.cc » ('j') | components/password_manager/core/browser/password_manager_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_proxy_mac.cc

diff --git a/chrome/browser/password_manager/password_store_proxy_mac.cc b/chrome/browser/password_manager/password_store_proxy_mac.cc

index 3ed1a3f6e948ebedeaaba58f6f70666b3e5dc56b..27564789878c6759ded01da3fc971b211d9d9add 100644

--- a/chrome/browser/password_manager/password_store_proxy_mac.cc

+++ b/chrome/browser/password_manager/password_store_proxy_mac.cc

@@ -166,6 +166,14 @@ PasswordStoreChangeList PasswordStoreProxyMac::RemoveLoginImpl(

return GetBackend()->RemoveLoginImpl(form);

}

+PasswordStoreChangeList PasswordStoreProxyMac::RemoveLoginsByOriginAndTimeImpl(

+ const url::Origin& origin,

+ base::Time delete_begin,

+ base::Time delete_end) {

+ return GetBackend()->RemoveLoginsByOriginAndTimeImpl(origin, delete_begin,

+ delete_end);

PasswordStoreChangeList PasswordStoreProxyMac::RemoveLoginsCreatedBetweenImpl(

base::Time delete_begin,

base::Time delete_end) {