mac: Add NotifyServer::DefaultInterface, a default no-op implementation

handler/mac/exception_handler_server.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "handler/mac/exception_handler_server.h"
 
 #include "base/logging.h"
 #include "base/mac/mach_logging.h"
 #include "util/mach/composite_mach_message_server.h"
 #include "util/mach/mach_extensions.h"
 #include "util/mach/mach_message.h"
 #include "util/mach/mach_message_server.h"
 #include "util/mach/notify_server.h"
 
 namespace crashpad {
 
 namespace {
 
 class ExceptionHandlerServerRun : public UniversalMachExcServer::Interface,
-                                  public NotifyServer::Interface {
+                                  public NotifyServer::DefaultInterface {
  public:
   ExceptionHandlerServerRun(
       mach_port_t exception_port,
       UniversalMachExcServer::Interface* exception_interface)
       : UniversalMachExcServer::Interface(),
-        NotifyServer::Interface(),
+        NotifyServer::DefaultInterface(),
         mach_exc_server_(this),
         notify_server_(this),
         composite_mach_message_server_(),
         exception_interface_(exception_interface),
         exception_port_(exception_port),
         notify_port_(NewMachPort(MACH_PORT_RIGHT_RECEIVE)),
         running_(true) {
     CHECK(notify_port_.is_valid());
 
     composite_mach_message_server_.AddHandler(&mach_exc_server_);
@@ skipping 90 matching lines @@
                                                     code_count,
                                                     flavor,
                                                     old_state,
                                                     old_state_count,
                                                     new_state,
                                                     new_state_count,
                                                     trailer,
                                                     destroy_complex_request);
   }
 
-  // NotifyServer::Interface:
-
-  kern_return_t DoMachNotifyPortDeleted(
-      notify_port_t notify,
-      mach_port_name_t name,
-      const mach_msg_trailer_t* trailer) override {
-    return UnimplementedNotifyRoutine(notify);
-  }
-
-  kern_return_t DoMachNotifyPortDestroyed(notify_port_t notify,
-                                          mach_port_t rights,
-                                          const mach_msg_trailer_t* trailer,
-                                          bool* destroy_request) override {
-    *destroy_request = true;
-    return UnimplementedNotifyRoutine(notify);
-  }
+  // NotifyServer::DefaultInterface:
 
   kern_return_t DoMachNotifyNoSenders(
       notify_port_t notify,
       mach_port_mscount_t mscount,
       const mach_msg_trailer_t* trailer) override {
     if (notify != notify_port_) {
       // The message was received as part of a port set. This check ensures that
       // only the authorized sender of the no-senders notification is able to
       // stop the exception server. Otherwise, a malicious client would be able
       // to craft and send a no-senders notification via its exception port, and
       // cause the handler to stop processing exceptions and exit.
       LOG(WARNING) << "notify port mismatch";
       return KERN_FAILURE;
     }
 
     running_ = false;
 
     return KERN_SUCCESS;
   }
 
-  kern_return_t DoMachNotifySendOnce(
-      notify_port_t notify,
-      const mach_msg_trailer_t* trailer) override {
-    return UnimplementedNotifyRoutine(notify);
-  }
-
-  kern_return_t DoMachNotifyDeadName(
-      notify_port_t notify,
-      mach_port_name_t name,
-      const mach_msg_trailer_t* trailer) override {
-    return UnimplementedNotifyRoutine(notify);
-  }
-
  private:
-  kern_return_t UnimplementedNotifyRoutine(notify_port_t notify) {
-    // Most of the routines in the notify subsystem are not expected to be
-    // called.
-    if (notify != notify_port_) {
-      LOG(WARNING) << "notify port mismatch";
-      return KERN_FAILURE;
-    }
-
-    NOTREACHED();
-    return MIG_BAD_ID;
-  }
-
   UniversalMachExcServer mach_exc_server_;
   NotifyServer notify_server_;
   CompositeMachMessageServer composite_mach_message_server_;
   UniversalMachExcServer::Interface* exception_interface_;  // weak
   mach_port_t exception_port_;  // weak
   base::mac::ScopedMachReceiveRight notify_port_;
   bool running_;
 
   DISALLOW_COPY_AND_ASSIGN(ExceptionHandlerServerRun);
 };
 
 }  // namespace
 
 ExceptionHandlerServer::ExceptionHandlerServer(
     base::mac::ScopedMachReceiveRight receive_port)
     : receive_port_(receive_port.Pass()) {
   CHECK(receive_port_.is_valid());
 }
 
 ExceptionHandlerServer::~ExceptionHandlerServer() {
 }
 
 void ExceptionHandlerServer::Run(
     UniversalMachExcServer::Interface* exception_interface) {
   ExceptionHandlerServerRun run(receive_port_.get(), exception_interface);
   run.Run();
 }
 
 }  // namespace crashpad