Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1414413006: mac: Add NotifyServer::DefaultInterface, a default no-op implementation (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Add NotifyServer::DefaultInterface, a default no-op implementation Each routine in this implementation returns MIG_BAD_ID. These routines may be overridden. Most things that implement NotifyServer::Interface will only need to implement one of the interface routines. Since another user of NotifyServer will be added soon, it makes sense to provide a default no-op implementation rather than forcing everyone to write the same no-op boilerplate repeatedly. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c1b841442fc96c24945046686062b4021bde1c87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -43 lines) Patch
M handler/mac/exception_handler_server.cc View 3 chunks +3 lines, -43 lines 0 comments Download
M util/mach/notify_server.h View 2 chunks +49 lines, -0 lines 0 comments Download
M util/mach/notify_server.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-10-30 14:28:01 UTC) #2
Robert Sesek
LGTM
5 years, 1 month ago (2015-10-30 17:47:16 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-10-30 19:44:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1b841442fc96c24945046686062b4021bde1c87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698