Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1414413004: Distinguish Call::CallType::PROPERTY_CALL further. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_issue-4521
Patch Set: Ports. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 3062 matching lines...) Expand 10 before | Expand all | Expand 10 after
3073 RecordJSReturnSite(expr); 3073 RecordJSReturnSite(expr);
3074 // Restore context register. 3074 // Restore context register.
3075 __ lw(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); 3075 __ lw(cp, MemOperand(fp, StandardFrameConstants::kContextOffset));
3076 context()->DropAndPlug(1, v0); 3076 context()->DropAndPlug(1, v0);
3077 } else if (call_type == Call::GLOBAL_CALL) { 3077 } else if (call_type == Call::GLOBAL_CALL) {
3078 EmitCallWithLoadIC(expr); 3078 EmitCallWithLoadIC(expr);
3079 } else if (call_type == Call::LOOKUP_SLOT_CALL) { 3079 } else if (call_type == Call::LOOKUP_SLOT_CALL) {
3080 // Call to a lookup slot (dynamically introduced variable). 3080 // Call to a lookup slot (dynamically introduced variable).
3081 PushCalleeAndWithBaseObject(expr); 3081 PushCalleeAndWithBaseObject(expr);
3082 EmitCall(expr); 3082 EmitCall(expr);
3083 } else if (call_type == Call::PROPERTY_CALL) { 3083 } else if (call_type == Call::NAMED_PROPERTY_CALL) {
3084 Property* property = callee->AsProperty(); 3084 Property* property = callee->AsProperty();
3085 bool is_named_call = property->key()->IsPropertyName(); 3085 VisitForStackValue(property->obj());
3086 if (property->IsSuperAccess()) { 3086 EmitCallWithLoadIC(expr);
3087 if (is_named_call) { 3087 } else if (call_type == Call::KEYED_PROPERTY_CALL) {
3088 EmitSuperCallWithLoadIC(expr); 3088 Property* property = callee->AsProperty();
3089 } else { 3089 VisitForStackValue(property->obj());
3090 EmitKeyedSuperCallWithLoadIC(expr); 3090 EmitKeyedCallWithLoadIC(expr, property->key());
3091 } 3091 } else if (call_type == Call::NAMED_SUPER_PROPERTY_CALL) {
3092 } else { 3092 EmitSuperCallWithLoadIC(expr);
3093 VisitForStackValue(property->obj()); 3093 } else if (call_type == Call::KEYED_SUPER_PROPERTY_CALL) {
3094 if (is_named_call) { 3094 EmitKeyedSuperCallWithLoadIC(expr);
3095 EmitCallWithLoadIC(expr);
3096 } else {
3097 EmitKeyedCallWithLoadIC(expr, property->key());
3098 }
3099 }
3100 } else if (call_type == Call::SUPER_CALL) { 3095 } else if (call_type == Call::SUPER_CALL) {
3101 EmitSuperConstructorCall(expr); 3096 EmitSuperConstructorCall(expr);
3102 } else { 3097 } else {
3103 DCHECK(call_type == Call::OTHER_CALL); 3098 DCHECK(call_type == Call::OTHER_CALL);
3104 // Call to an arbitrary expression not handled specially above. 3099 // Call to an arbitrary expression not handled specially above.
3105 VisitForStackValue(callee); 3100 VisitForStackValue(callee);
3106 __ LoadRoot(a1, Heap::kUndefinedValueRootIndex); 3101 __ LoadRoot(a1, Heap::kUndefinedValueRootIndex);
3107 __ push(a1); 3102 __ push(a1);
3108 // Emit function call. 3103 // Emit function call.
3109 EmitCall(expr); 3104 EmitCall(expr);
(...skipping 2045 matching lines...) Expand 10 before | Expand all | Expand 10 after
5155 reinterpret_cast<uint32_t>( 5150 reinterpret_cast<uint32_t>(
5156 isolate->builtins()->OsrAfterStackCheck()->entry())); 5151 isolate->builtins()->OsrAfterStackCheck()->entry()));
5157 return OSR_AFTER_STACK_CHECK; 5152 return OSR_AFTER_STACK_CHECK;
5158 } 5153 }
5159 5154
5160 5155
5161 } // namespace internal 5156 } // namespace internal
5162 } // namespace v8 5157 } // namespace v8
5163 5158
5164 #endif // V8_TARGET_ARCH_MIPS 5159 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698