Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1414413004: Distinguish Call::CallType::PROPERTY_CALL further. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_issue-4521
Patch Set: Ports. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 2960 matching lines...) Expand 10 before | Expand all | Expand 10 after
2971 // Restore context register. 2971 // Restore context register.
2972 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset)); 2972 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
2973 context()->DropAndPlug(1, eax); 2973 context()->DropAndPlug(1, eax);
2974 2974
2975 } else if (call_type == Call::GLOBAL_CALL) { 2975 } else if (call_type == Call::GLOBAL_CALL) {
2976 EmitCallWithLoadIC(expr); 2976 EmitCallWithLoadIC(expr);
2977 } else if (call_type == Call::LOOKUP_SLOT_CALL) { 2977 } else if (call_type == Call::LOOKUP_SLOT_CALL) {
2978 // Call to a lookup slot (dynamically introduced variable). 2978 // Call to a lookup slot (dynamically introduced variable).
2979 PushCalleeAndWithBaseObject(expr); 2979 PushCalleeAndWithBaseObject(expr);
2980 EmitCall(expr); 2980 EmitCall(expr);
2981 } else if (call_type == Call::PROPERTY_CALL) { 2981 } else if (call_type == Call::NAMED_PROPERTY_CALL) {
2982 Property* property = callee->AsProperty(); 2982 Property* property = callee->AsProperty();
2983 bool is_named_call = property->key()->IsPropertyName(); 2983 VisitForStackValue(property->obj());
2984 if (property->IsSuperAccess()) { 2984 EmitCallWithLoadIC(expr);
2985 if (is_named_call) { 2985 } else if (call_type == Call::KEYED_PROPERTY_CALL) {
2986 EmitSuperCallWithLoadIC(expr); 2986 Property* property = callee->AsProperty();
2987 } else { 2987 VisitForStackValue(property->obj());
2988 EmitKeyedSuperCallWithLoadIC(expr); 2988 EmitKeyedCallWithLoadIC(expr, property->key());
2989 } 2989 } else if (call_type == Call::NAMED_SUPER_PROPERTY_CALL) {
2990 } else { 2990 EmitSuperCallWithLoadIC(expr);
2991 VisitForStackValue(property->obj()); 2991 } else if (call_type == Call::KEYED_SUPER_PROPERTY_CALL) {
2992 if (is_named_call) { 2992 EmitKeyedSuperCallWithLoadIC(expr);
2993 EmitCallWithLoadIC(expr);
2994 } else {
2995 EmitKeyedCallWithLoadIC(expr, property->key());
2996 }
2997 }
2998 } else if (call_type == Call::SUPER_CALL) { 2993 } else if (call_type == Call::SUPER_CALL) {
2999 EmitSuperConstructorCall(expr); 2994 EmitSuperConstructorCall(expr);
3000 } else { 2995 } else {
3001 DCHECK(call_type == Call::OTHER_CALL); 2996 DCHECK(call_type == Call::OTHER_CALL);
3002 // Call to an arbitrary expression not handled specially above. 2997 // Call to an arbitrary expression not handled specially above.
3003 VisitForStackValue(callee); 2998 VisitForStackValue(callee);
3004 __ push(Immediate(isolate()->factory()->undefined_value())); 2999 __ push(Immediate(isolate()->factory()->undefined_value()));
3005 // Emit function call. 3000 // Emit function call.
3006 EmitCall(expr); 3001 EmitCall(expr);
3007 } 3002 }
(...skipping 2053 matching lines...) Expand 10 before | Expand all | Expand 10 after
5061 Assembler::target_address_at(call_target_address, 5056 Assembler::target_address_at(call_target_address,
5062 unoptimized_code)); 5057 unoptimized_code));
5063 return OSR_AFTER_STACK_CHECK; 5058 return OSR_AFTER_STACK_CHECK;
5064 } 5059 }
5065 5060
5066 5061
5067 } // namespace internal 5062 } // namespace internal
5068 } // namespace v8 5063 } // namespace v8
5069 5064
5070 #endif // V8_TARGET_ARCH_IA32 5065 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698