Distinguish Call::CallType::PROPERTY_CALL further.

Distinguish Call::CallType::PROPERTY_CALL further.

Most use sites of Call::GetCallType already distinguish the property
call case (i.e. formerly known as Call::PROPERTY_CALL) further. This
introduces this distinction to simplify use sites.

R=rossberg@chromium.org

Committed: https://crrev.com/5cc4ba59d3a057ff4b60326276b725b9a7920586
Cr-Commit-Position: refs/heads/master@{#31663}

[Michael Starzinger, 2015-10-29 12:56:34]

mstarzinger@chromium.org changed reviewers:
+ adamk@chromium.org, rmcilroy@chromium.org

[Michael Starzinger, 2015-10-29 12:56:34]

Note that architecture ports are still missing, only ia32 so far. But I wanted
to get a first round of comments before I do the ports, because it's a pretty
cross-cutting change.

Andreas: PTAL.
Ross, Adam: RFC.

[rossberg, 2015-10-29 13:14:30]

Looks good to me so far

https://codereview.chromium.org/1414413004/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1414413004/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:2942: if (call_type ==
Call::POSSIBLY_EVAL_CALL) {
Perhaps this should be turned into a switch now. (But then you have to port that
to all platforms :-P)

[Michael Starzinger, 2015-10-29 13:20:49]

https://codereview.chromium.org/1414413004/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1414413004/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:2942: if (call_type ==
Call::POSSIBLY_EVAL_CALL) {
On 2015/10/29 13:14:30, rossberg wrote:
> Perhaps this should be turned into a switch now. (But then you have to port
that
> to all platforms :-P)

Would you accept an "in a follow-up CL" voucher for that? ;)

[rossberg, 2015-10-29 13:22:21]

https://codereview.chromium.org/1414413004/diff/1/src/full-codegen/ia32/full-...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1414413004/diff/1/src/full-codegen/ia32/full-...
src/full-codegen/ia32/full-codegen-ia32.cc:2942: if (call_type ==
Call::POSSIBLY_EVAL_CALL) {
On 2015/10/29 13:20:49, Michael Starzinger wrote:
> On 2015/10/29 13:14:30, rossberg wrote:
> > Perhaps this should be turned into a switch now. (But then you have to port
> that
> > to all platforms :-P)
> 
> Would you accept an "in a follow-up CL" voucher for that? ;)

Certainly. :)

[rmcilroy, 2015-10-29 14:10:41]

Interpreter LGTM, thanks!

[Michael Starzinger, 2015-10-29 14:10:53]

The copy-and-p... ahem, I mean "ports" are done. :)

[adamk, 2015-10-29 14:39:01]

lgtm too

[rossberg, 2015-10-29 16:44:17]

lgtm

[Michael Starzinger, 2015-10-29 17:14:14]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-10-29 17:14:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414413004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414413004/20001

[commit-bot: I haz the power, 2015-10-29 17:16:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-29 17:16:32]

Patchset 2 (id:??) landed as
https://crrev.com/5cc4ba59d3a057ff4b60326276b725b9a7920586
Cr-Commit-Position: refs/heads/master@{#31663}