Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414403003: Fix HasProperty/HasElement for Proxies on the prototype chain (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix HasProperty/HasElement for Proxies on the prototype chain Committed: https://crrev.com/41775a3e732abb9c9fb8a34b75d7a40d59b7be16 Cr-Commit-Position: refs/heads/master@{#31775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -43 lines) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 3 chunks +40 lines, -6 lines 0 comments Download
M src/objects-inl.h View 2 chunks +11 lines, -36 lines 0 comments Download
M test/mjsunit/harmony/proxies.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL. CQ it if you like it.
5 years, 1 month ago (2015-11-03 17:54:26 UTC) #2
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-04 09:52:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414403003/1
5 years, 1 month ago (2015-11-04 09:52:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 10:17:12 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 10:17:54 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/41775a3e732abb9c9fb8a34b75d7a40d59b7be16
Cr-Commit-Position: refs/heads/master@{#31775}

Powered by Google App Engine
This is Rietveld 408576698