Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Issue 1414403002: Add CommandLineArgumentParameter and use it for WebView tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-cr-526885-read-nested-annotations
Patch Set: One more test needs to be excluded Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
index 1f2bcfe70fb7bef9232f51c602c132cbb2ab6510..6d536bbe05bb4aec4b194437f8ae1584bd6376c8 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
@@ -30,6 +30,7 @@ import org.chromium.android_webview.test.util.JSUtils;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.parameter.ParameterizedTest;
import org.chromium.content.browser.BindingManager;
import org.chromium.content.browser.ChildProcessConnection;
import org.chromium.content.browser.ChildProcessLauncher;
@@ -79,6 +80,8 @@ public class AwContentsTest extends AwTestBase {
@LargeTest
@Feature({"AndroidWebView"})
+ // Run in single-process mode only. Blocked by rendering support crbug.com/526842.
+ @ParameterizedTest.Set
public void testCreateLoadDestroyManyTimes() throws Throwable {
for (int i = 0; i < 10; ++i) {
AwTestContainerView testView = createAwTestContainerViewOnMainSync(mContentsClient);
@@ -588,11 +591,15 @@ public class AwContentsTest extends AwTestBase {
public void releaseAllModerateBindings() {}
}
+ /**
+ * Verifies that a child process is actually gets created with WEBVIEW_SANDBOXED_RENDERER flag.
+ */
@Feature({"AndroidWebView"})
@SmallTest
@CommandLineFlags.Add({
AwSwitches.WEBVIEW_SANDBOXED_RENDERER,
ContentSwitches.IPC_SYNC_COMPOSITING})
+ @ParameterizedTest.Set
public void testSandboxedRendererWorks() throws Throwable {
MockBindingManager bindingManager = new MockBindingManager();
ChildProcessLauncher.setBindingManagerForTesting(bindingManager);

Powered by Google App Engine
This is Rietveld 408576698