Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java

Issue 1414403002: Add CommandLineArgumentParameter and use it for WebView tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-cr-526885-read-nested-annotations
Patch Set: One more test needs to be excluded Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
index 9e1e6edd3d0113dce48e397058df086befd9ea40..4329707f1804163b821a765fe5145c175db038cf 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
@@ -14,6 +14,7 @@ import org.chromium.android_webview.test.util.JSUtils;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.parameter.ParameterizedTest;
import org.chromium.content.browser.test.util.CallbackHelper;
import org.chromium.content.browser.test.util.DOMUtils;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnEvaluateJavaScriptResultHelper;
@@ -726,6 +727,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView", "Navigation"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testCalledOn302Redirect() throws Throwable {
final String redirectTargetUrl = createRedirectTargetPage();
final String redirectUrl = mWebServer.setRedirect("/302.html", redirectTargetUrl);
@@ -734,6 +737,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView", "Navigation"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testCalledOnMetaRefreshRedirect() throws Throwable {
final String redirectTargetUrl = createRedirectTargetPage();
final String redirectUrl = addPageToTestServer("/meta_refresh.html",
@@ -744,6 +749,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView", "Navigation"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testCalledOnJavaScriptLocationImmediateAssignRedirect()
throws Throwable {
final String redirectTargetUrl = createRedirectTargetPage();
@@ -754,6 +761,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView", "Navigation"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testCalledOnJavaScriptLocationImmediateReplaceRedirect()
throws Throwable {
final String redirectTargetUrl = createRedirectTargetPage();
@@ -764,6 +773,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView", "Navigation"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testCalledOnJavaScriptLocationDelayedAssignRedirect()
throws Throwable {
final String redirectTargetUrl = createRedirectTargetPage();
@@ -774,6 +785,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView", "Navigation"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testCalledOnJavaScriptLocationDelayedReplaceRedirect()
throws Throwable {
final String redirectTargetUrl = createRedirectTargetPage();
@@ -890,6 +903,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testNullContentsClientOpenLink() throws Throwable {
try {
// The test will fire real intents through the test activity.
@@ -940,6 +955,8 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testNullContentsClientClickableContent() throws Throwable {
try {
// The test will fire real intents through the test activity.
@@ -1023,12 +1040,16 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testClickableContent() throws Throwable {
doTestClickableContent(true);
}
@SmallTest
@Feature({"AndroidWebView"})
+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.
+ @ParameterizedTest.Set
public void testClickableContentInIframe() throws Throwable {
doTestClickableContent(false);
}

Powered by Google App Engine
This is Rietveld 408576698