android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java - Issue 1414403002: Add CommandLineArgumentParameter and use it for WebView tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

Issue 1414403002: Add CommandLineArgumentParameter and use it for WebView tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-cr-526885-read-nested-annotations

Patch Set: Comments addressed Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ExternalVideoSurfaceContainerTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java » ('j') | base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

index 4237f48f5ffc25b0c50c11594cf844ab19e9086d..85c24a2e3080abe4622a937644eab6298cbdb55b 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

@@ -12,6 +12,7 @@ import org.chromium.android_webview.AwSettings;

import org.chromium.android_webview.test.util.CommonResources;

import org.chromium.base.test.util.DisabledTest;

import org.chromium.base.test.util.Feature;

+import org.chromium.base.test.util.parameter.ParameterizedTest;

import org.chromium.content.browser.test.util.HistoryUtils;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer;

import org.chromium.content_public.browser.WebContents;

@@ -185,6 +186,8 @@ public class LoadDataWithBaseUrlTest extends AwTestBase {

@SmallTest

@Feature({"AndroidWebView"})

+ // Run in single-process mode only. Blocked by multiple RVHs crbug.com/533516.

+ @ParameterizedTest.Set

public void testHistoryUrl() throws Throwable {

final String pageHtml = "<html><body>Hello, world!</body></html>";

@@ -203,6 +206,8 @@ public class LoadDataWithBaseUrlTest extends AwTestBase {

@SmallTest

@Feature({"AndroidWebView"})

+ // Run in single-process mode only. Blocked by multiple RVHs crbug.com/533516.

+ @ParameterizedTest.Set

public void testOnPageFinishedUrlIsBaseUrl() throws Throwable {

final String pageHtml = "<html><body>Hello, world!</body></html>";

final String baseUrl = "http://example.com/";