android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java - Issue 1414403002: Add CommandLineArgumentParameter and use it for WebView tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

Issue 1414403002: Add CommandLineArgumentParameter and use it for WebView tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-cr-526885-read-nested-annotations

Patch Set: Comments addressed Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnScaleChangedTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java » ('j') | build/android/pylib/instrumentation/instrumentation_test_instance.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

index 7a3c609501a5471055ccd62f0d2aa7089ddc534f..661152908183df516b1aa1134b042932dc618f2b 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

@@ -14,6 +14,7 @@ import org.chromium.android_webview.test.util.CommonResources;

import org.chromium.android_webview.test.util.JSUtils;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.TestFileUtil;

+import org.chromium.base.test.util.parameter.ParameterizedTest;

import org.chromium.content.browser.test.util.CallbackHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnReceivedErrorHelper;

import org.chromium.net.test.util.TestWebServer;

@@ -223,6 +224,8 @@ public class AwContentsClientShouldInterceptRequestTest extends AwTestBase {

@SmallTest

@Feature({"AndroidWebView"})

+ // Run in single-process mode only. Blocked by software draws support crbug.com/545611.

+ @ParameterizedTest.Set

public void testCalledWithCorrectHasUserGestureParam() throws Throwable {

final String aboutPageUrl = addAboutPageToTestServer(mWebServer);

final String pageWithLinkUrl = addPageToTestServer(mWebServer, "/page_with_link.html",