Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 1414393010: Adding Skia Debugger documentation (Closed)

Created:
5 years, 1 month ago by hcm
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adding Skia Debugger documentation BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1414393010 Committed: https://skia.googlesource.com/skia/+/6065d8eae621b02405dc44481cb8cc620de01a0d

Patch Set 1 #

Patch Set 2 : fix to docserver go command #

Total comments: 2

Patch Set 3 : formatting fixes #

Total comments: 1

Patch Set 4 : upgrade qt version tested #

Patch Set 5 : fix one more reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -1 line) Patch
A site/dev/tools/debugger.md View 1 2 3 4 1 chunk +122 lines, -0 lines 0 comments Download
A site/dev/tools/debugger.png View Binary file 0 comments Download
M site/dev/tools/markdown.md View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
hcm
On 2015/11/05 20:12:43, hcm wrote: > mailto:hcm@google.com changed reviewers: > + mailto:djsollen@google.com, mailto:reed@google.com, mailto:robertphillips@google.com PTAL- ...
5 years, 1 month ago (2015-11-05 20:14:26 UTC) #3
djsollen
https://codereview.chromium.org/1414393010/diff/20001/site/dev/tools/debugger.md File site/dev/tools/debugger.md (right): https://codereview.chromium.org/1414393010/diff/20001/site/dev/tools/debugger.md#newcode53 site/dev/tools/debugger.md:53: <!--?prettify?--> the preview shows this prettify as text. https://codereview.chromium.org/1414393010/diff/20001/site/dev/tools/debugger.md#newcode62 ...
5 years, 1 month ago (2015-11-05 20:57:17 UTC) #4
hcm
On 2015/11/05 20:57:17, djsollen wrote: > https://codereview.chromium.org/1414393010/diff/20001/site/dev/tools/debugger.md > File site/dev/tools/debugger.md (right): > > https://codereview.chromium.org/1414393010/diff/20001/site/dev/tools/debugger.md#newcode53 > ...
5 years, 1 month ago (2015-11-05 21:20:28 UTC) #5
mtklein
https://codereview.chromium.org/1414393010/diff/40001/site/dev/tools/debugger.md File site/dev/tools/debugger.md (right): https://codereview.chromium.org/1414393010/diff/40001/site/dev/tools/debugger.md#newcode20 site/dev/tools/debugger.md:20: Note that the debugger has been tested with Qt ...
5 years, 1 month ago (2015-11-05 21:24:38 UTC) #7
hcm
On 2015/11/05 21:24:38, mtklein wrote: > https://codereview.chromium.org/1414393010/diff/40001/site/dev/tools/debugger.md > File site/dev/tools/debugger.md (right): > > https://codereview.chromium.org/1414393010/diff/40001/site/dev/tools/debugger.md#newcode20 > ...
5 years, 1 month ago (2015-11-05 21:31:18 UTC) #8
robertphillips
Is the debugger.png image supposed to be broken in the preview?
5 years, 1 month ago (2015-11-06 12:27:21 UTC) #9
djsollen
lgtm
5 years, 1 month ago (2015-11-06 17:08:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414393010/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414393010/80001
5 years, 1 month ago (2015-11-06 19:28:34 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 19:29:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6065d8eae621b02405dc44481cb8cc620de01a0d

Powered by Google App Engine
This is Rietveld 408576698