Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1414393006: Revert "Add type cast definitions for CPDF_Reference." (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add type cast definitions for CPDF_Reference." This is causing pixel test failures on the bots. FAILURE: bug_543018_2.in FAILURE: bug_543018_1.in FAILURE: bug_524043_1.in This reverts commit 9024e026dae1af064b8467bb0f62278417fb82d1. Add type cast definitions for CPDF_Reference. This Cl adds ToReference, CPDF_Object::AsReference and CPDF_Object::IsReference and updates the src to use them as needed. BUG=pdfium:201 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1420973002 . Committed: https://pdfium.googlesource.com/pdfium/+/7e155865c90cc1115cc7193b7646a341d8f9093e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -160 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 3 chunks +0 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 2 chunks +14 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +38 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 2 chunks +9 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 11 chunks +64 lines, -43 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 15 chunks +77 lines, -58 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 4 chunks +16 lines, -14 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dsinclair
5 years, 1 month ago (2015-10-26 17:02:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e155865c90cc1115cc7193b7646a341d8f9093e (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698